* [PATCH -next] scsi: bnx2i: remove set but not used variable 'cid_num'
@ 2018-11-12 1:54 YueHaibing
2018-11-12 6:18 ` Javali, Nilesh
2018-11-22 3:26 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2018-11-12 1:54 UTC (permalink / raw)
To: kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/bnx2i/bnx2i_hwi.c: In function 'bnx2i_process_ofld_cmpl':
drivers/scsi/bnx2i/bnx2i_hwi.c:2430:6: warning:
variable 'cid_num' set but not used [-Wunused-but-set-variable]
It never used since commit
cf4e6363859d ("[SCSI] bnx2i: Add bnx2i iSCSI driver.")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/bnx2i/bnx2i_hwi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c b/drivers/scsi/bnx2i/bnx2i_hwi.c
index 6bad268..91f5316 100644
--- a/drivers/scsi/bnx2i/bnx2i_hwi.c
+++ b/drivers/scsi/bnx2i/bnx2i_hwi.c
@@ -2427,7 +2427,6 @@ static void bnx2i_process_ofld_cmpl(struct bnx2i_hba *hba,
{
u32 cid_addr;
struct bnx2i_endpoint *ep;
- u32 cid_num;
ep = bnx2i_find_ep_in_ofld_list(hba, ofld_kcqe->iscsi_conn_id);
if (!ep) {
@@ -2462,7 +2461,6 @@ static void bnx2i_process_ofld_cmpl(struct bnx2i_hba *hba,
} else {
ep->state = EP_STATE_OFLD_COMPL;
cid_addr = ofld_kcqe->iscsi_conn_context_id;
- cid_num = bnx2i_get_cid_num(ep);
ep->ep_cid = cid_addr;
ep->qp.ctx_base = NULL;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] scsi: bnx2i: remove set but not used variable 'cid_num'
2018-11-12 1:54 [PATCH -next] scsi: bnx2i: remove set but not used variable 'cid_num' YueHaibing
@ 2018-11-12 6:18 ` Javali, Nilesh
2018-11-22 3:26 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Javali, Nilesh @ 2018-11-12 6:18 UTC (permalink / raw)
To: kernel-janitors
On 11/12/18, 7:24 AM, "YueHaibing" <yuehaibing@huawei.com> wrote:
>External Email
>
>Fixes gcc '-Wunused-but-set-variable' warning:
>
>drivers/scsi/bnx2i/bnx2i_hwi.c: In function 'bnx2i_process_ofld_cmpl':
>drivers/scsi/bnx2i/bnx2i_hwi.c:2430:6: warning:
> variable 'cid_num' set but not used [-Wunused-but-set-variable]
>
>It never used since commit
> cf4e6363859d ("[SCSI] bnx2i: Add bnx2i iSCSI driver.")
>
>Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>---
> drivers/scsi/bnx2i/bnx2i_hwi.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c
>b/drivers/scsi/bnx2i/bnx2i_hwi.c
>index 6bad268..91f5316 100644
>--- a/drivers/scsi/bnx2i/bnx2i_hwi.c
>+++ b/drivers/scsi/bnx2i/bnx2i_hwi.c
>@@ -2427,7 +2427,6 @@ static void bnx2i_process_ofld_cmpl(struct
>bnx2i_hba *hba,
> {
> u32 cid_addr;
> struct bnx2i_endpoint *ep;
>- u32 cid_num;
>
> ep = bnx2i_find_ep_in_ofld_list(hba, ofld_kcqe->iscsi_conn_id);
> if (!ep) {
>@@ -2462,7 +2461,6 @@ static void bnx2i_process_ofld_cmpl(struct
>bnx2i_hba *hba,
> } else {
> ep->state = EP_STATE_OFLD_COMPL;
> cid_addr = ofld_kcqe->iscsi_conn_context_id;
>- cid_num = bnx2i_get_cid_num(ep);
> ep->ep_cid = cid_addr;
> ep->qp.ctx_base = NULL;
> }
>
Thanks.
Acked-by: Nilesh Javali <nilesh.javali@cavium.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] scsi: bnx2i: remove set but not used variable 'cid_num'
2018-11-12 1:54 [PATCH -next] scsi: bnx2i: remove set but not used variable 'cid_num' YueHaibing
2018-11-12 6:18 ` Javali, Nilesh
@ 2018-11-22 3:26 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2018-11-22 3:26 UTC (permalink / raw)
To: kernel-janitors
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/bnx2i/bnx2i_hwi.c: In function 'bnx2i_process_ofld_cmpl':
> drivers/scsi/bnx2i/bnx2i_hwi.c:2430:6: warning:
> variable 'cid_num' set but not used [-Wunused-but-set-variable]
>
> It never used since commit
> cf4e6363859d ("[SCSI] bnx2i: Add bnx2i iSCSI driver.")
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-22 3:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-12 1:54 [PATCH -next] scsi: bnx2i: remove set but not used variable 'cid_num' YueHaibing
2018-11-12 6:18 ` Javali, Nilesh
2018-11-22 3:26 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.