* [PATCH] scsi: qla2xxx: Off by one in qlt_ctio_to_cmd()
@ 2017-07-10 8:47 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-07-10 8:47 UTC (permalink / raw)
To: qla2xxx-upstream, Nicholas Bellinger
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi,
kernel-janitors
There are "req->num_outstanding_cmds" elements in the
req->outstanding_cmds[] array so the > here should be >=.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 6e4794367e0b..ecd1a95511f9 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -3728,7 +3728,7 @@ static struct qla_tgt_cmd *qlt_ctio_to_cmd(struct scsi_qla_host *vha,
h &= QLA_CMD_HANDLE_MASK;
if (h != QLA_TGT_NULL_HANDLE) {
- if (unlikely(h > req->num_outstanding_cmds)) {
+ if (unlikely(h >= req->num_outstanding_cmds)) {
ql_dbg(ql_dbg_tgt, vha, 0xe052,
"qla_target(%d): Wrong handle %x received\n",
vha->vp_idx, handle);
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] scsi: qla2xxx: Off by one in qlt_ctio_to_cmd()
@ 2017-07-10 8:47 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-07-10 8:47 UTC (permalink / raw)
To: qla2xxx-upstream, Nicholas Bellinger
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi,
kernel-janitors
There are "req->num_outstanding_cmds" elements in the
req->outstanding_cmds[] array so the > here should be >=.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 6e4794367e0b..ecd1a95511f9 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -3728,7 +3728,7 @@ static struct qla_tgt_cmd *qlt_ctio_to_cmd(struct scsi_qla_host *vha,
h &= QLA_CMD_HANDLE_MASK;
if (h != QLA_TGT_NULL_HANDLE) {
- if (unlikely(h > req->num_outstanding_cmds)) {
+ if (unlikely(h >= req->num_outstanding_cmds)) {
ql_dbg(ql_dbg_tgt, vha, 0xe052,
"qla_target(%d): Wrong handle %x received\n",
vha->vp_idx, handle);
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: qla2xxx: Off by one in qlt_ctio_to_cmd()
2017-07-10 8:47 ` Dan Carpenter
@ 2017-07-11 9:14 ` Nicholas A. Bellinger
-1 siblings, 0 replies; 6+ messages in thread
From: Nicholas A. Bellinger @ 2017-07-11 9:14 UTC (permalink / raw)
To: Dan Carpenter
Cc: qla2xxx-upstream, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, kernel-janitors
On Mon, 2017-07-10 at 11:47 +0300, Dan Carpenter wrote:
> There are "req->num_outstanding_cmds" elements in the
> req->outstanding_cmds[] array so the > here should be >=.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 6e4794367e0b..ecd1a95511f9 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -3728,7 +3728,7 @@ static struct qla_tgt_cmd *qlt_ctio_to_cmd(struct scsi_qla_host *vha,
> h &= QLA_CMD_HANDLE_MASK;
>
> if (h != QLA_TGT_NULL_HANDLE) {
> - if (unlikely(h > req->num_outstanding_cmds)) {
> + if (unlikely(h >= req->num_outstanding_cmds)) {
> ql_dbg(ql_dbg_tgt, vha, 0xe052,
> "qla_target(%d): Wrong handle %x received\n",
> vha->vp_idx, handle);
Nice catch.
Reviewed-by: Nicholas Bellinger <nab@linux-iscsi.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: qla2xxx: Off by one in qlt_ctio_to_cmd()
@ 2017-07-11 9:14 ` Nicholas A. Bellinger
0 siblings, 0 replies; 6+ messages in thread
From: Nicholas A. Bellinger @ 2017-07-11 9:14 UTC (permalink / raw)
To: Dan Carpenter
Cc: qla2xxx-upstream, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, kernel-janitors
On Mon, 2017-07-10 at 11:47 +0300, Dan Carpenter wrote:
> There are "req->num_outstanding_cmds" elements in the
> req->outstanding_cmds[] array so the > here should be >=.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 6e4794367e0b..ecd1a95511f9 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -3728,7 +3728,7 @@ static struct qla_tgt_cmd *qlt_ctio_to_cmd(struct scsi_qla_host *vha,
> h &= QLA_CMD_HANDLE_MASK;
>
> if (h != QLA_TGT_NULL_HANDLE) {
> - if (unlikely(h > req->num_outstanding_cmds)) {
> + if (unlikely(h >= req->num_outstanding_cmds)) {
> ql_dbg(ql_dbg_tgt, vha, 0xe052,
> "qla_target(%d): Wrong handle %x received\n",
> vha->vp_idx, handle);
Nice catch.
Reviewed-by: Nicholas Bellinger <nab@linux-iscsi.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Off by one in qlt_ctio_to_cmd()
2017-07-10 8:47 ` Dan Carpenter
@ 2017-07-12 21:20 ` Martin K. Petersen
-1 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2017-07-12 21:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: qla2xxx-upstream, Nicholas Bellinger, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, kernel-janitors
Dan,
> There are "req->num_outstanding_cmds" elements in the
> req->outstanding_cmds[] array so the > here should be >=.
Applied to 4.13/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Off by one in qlt_ctio_to_cmd()
@ 2017-07-12 21:20 ` Martin K. Petersen
0 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2017-07-12 21:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: qla2xxx-upstream, Nicholas Bellinger, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, kernel-janitors
Dan,
> There are "req->num_outstanding_cmds" elements in the
> req->outstanding_cmds[] array so the > here should be >=.
Applied to 4.13/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-07-12 21:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-10 8:47 [PATCH] scsi: qla2xxx: Off by one in qlt_ctio_to_cmd() Dan Carpenter
2017-07-10 8:47 ` Dan Carpenter
2017-07-11 9:14 ` Nicholas A. Bellinger
2017-07-11 9:14 ` Nicholas A. Bellinger
2017-07-12 21:20 ` Martin K. Petersen
2017-07-12 21:20 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.