From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.garry@huawei.com>
Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH] scsi: libsas: fix ata xfer length
Date: Sun, 19 Mar 2017 13:21:52 -0400 [thread overview]
Message-ID: <yq160j5ji6n.fsf@oracle.com> (raw)
In-Reply-To: <1489676848-103256-1-git-send-email-john.garry@huawei.com> (John Garry's message of "Thu, 16 Mar 2017 23:07:28 +0800")
John Garry <john.garry@huawei.com> writes:
John,
> The total ata xfer length may not be calculated properly,
> in that we do not use the proper method to get an sg element
> dma length.
>
> According to the code comment, sg_dma_len() should be used
> after dma_map_sg() is called.
>
> This issue was found by turning on the SMMUv3 in front of
> the hisi_sas controller in hip07. Multiple sg elements
> were being combined into a single element, but the original
> first element length was being use as the total xfer length.
Applied to 4.11/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.garry@huawei.com>
Cc: <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>
Subject: Re: [PATCH] scsi: libsas: fix ata xfer length
Date: Sun, 19 Mar 2017 13:21:52 -0400 [thread overview]
Message-ID: <yq160j5ji6n.fsf@oracle.com> (raw)
In-Reply-To: <1489676848-103256-1-git-send-email-john.garry@huawei.com> (John Garry's message of "Thu, 16 Mar 2017 23:07:28 +0800")
John Garry <john.garry@huawei.com> writes:
John,
> The total ata xfer length may not be calculated properly,
> in that we do not use the proper method to get an sg element
> dma length.
>
> According to the code comment, sg_dma_len() should be used
> after dma_map_sg() is called.
>
> This issue was found by turning on the SMMUv3 in front of
> the hisi_sas controller in hip07. Multiple sg elements
> were being combined into a single element, but the original
> first element length was being use as the total xfer length.
Applied to 4.11/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-03-19 17:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 15:07 [PATCH] scsi: libsas: fix ata xfer length John Garry
2017-03-16 15:07 ` John Garry
2017-03-19 17:21 ` Martin K. Petersen [this message]
2017-03-19 17:21 ` Martin K. Petersen
2017-03-20 8:59 ` John Garry
2017-03-20 8:59 ` John Garry
2017-03-20 14:21 ` Martin K. Petersen
2017-03-20 14:21 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq160j5ji6n.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.