* Re: [PATCH] scsi: iscsi: fix sysfs visibility checks for CHAP
[not found] <20241117194604.13827-1-leeman.duncan@gmail.com>
@ 2024-12-04 16:50 ` Lee Duncan
[not found] ` <CAPj3X_XGg+vT35aHVmxYONVpcjadAE6eSsa=nuUwP-+KHybiFw@mail.gmail.com>
1 sibling, 0 replies; 2+ messages in thread
From: Lee Duncan @ 2024-12-04 16:50 UTC (permalink / raw)
To: Martin K. Petersen, Hannes Reinecke
Cc: linux-scsi, linux-kernel, open-iscsi, lduncan
I see there's a spelling error in the description, so I'll resubmit.
On Sun, Nov 17, 2024 at 11:46 AM Lee Duncan <leeman.duncan@gmail.com> wrote:
>
> From: Lee Duncan <lduncan@suse.com>
>
> The username and password checks were backwards for the sysfs
> visibility checks, so correct them. This likely went unnoticed,
> since the visibility/writability for these attributes
> (username/password and mututual username/password) are all
> the same.
>
> Fixes: 1d063c17298d ('[SCSI] iscsi class: sysfs group is_visible callout for session attrs')
> Signed-off-by: Lee Duncan <lduncan@suse.com>
> ---
> drivers/scsi/scsi_transport_iscsi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index fde7de3b1e55..81c57e0e8d90 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -4587,13 +4587,13 @@ static umode_t iscsi_session_attr_is_visible(struct kobject *kobj,
> else if (attr == &dev_attr_sess_chap_out_idx.attr)
> param = ISCSI_PARAM_CHAP_OUT_IDX;
> else if (attr == &dev_attr_sess_password.attr)
> - param = ISCSI_PARAM_USERNAME;
> + param = ISCSI_PARAM_PASSWORD;
> else if (attr == &dev_attr_sess_password_in.attr)
> - param = ISCSI_PARAM_USERNAME_IN;
> + param = ISCSI_PARAM_PASSWORD_IN;
> else if (attr == &dev_attr_sess_username.attr)
> - param = ISCSI_PARAM_PASSWORD;
> + param = ISCSI_PARAM_USERNAME;
> else if (attr == &dev_attr_sess_username_in.attr)
> - param = ISCSI_PARAM_PASSWORD_IN;
> + param = ISCSI_PARAM_USERNAME_IN;
> else if (attr == &dev_attr_sess_fast_abort.attr)
> param = ISCSI_PARAM_FAST_ABORT;
> else if (attr == &dev_attr_sess_abort_tmo.attr)
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread