From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Matt Lupfer <mlupfer@ddn.com>
Cc: "mst\@redhat.com" <mst@redhat.com>,
"jasowang\@redhat.com" <jasowang@redhat.com>,
"pbonzini\@redhat.com" <pbonzini@redhat.com>,
"stefanha\@redhat.com" <stefanha@redhat.com>,
"jejb\@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen\@oracle.com" <martin.petersen@oracle.com>,
"virtualization\@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-scsi\@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed
Date: Tue, 10 Sep 2019 22:14:12 -0400 [thread overview]
Message-ID: <yq17e6ffukr.fsf@oracle.com> (raw)
In-Reply-To: <20190905181903.29756-1-mlupfer@ddn.com> (Matt Lupfer's message of "Thu, 5 Sep 2019 18:19:28 +0000")
Matt,
> The event handler calls scsi_scan_host() when events are missed, which
> will hotplug new LUNs. However, this function won't remove any
> unplugged LUNs. The result is that hotunplug doesn't work properly
> when the number of unplugged LUNs exceeds the event queue size
> (currently 8).
>
> Scan existing LUNs when events are missed to check if they are still
> present. If not, remove them.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Matt Lupfer <mlupfer@ddn.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"mst@redhat.com" <mst@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>
Subject: Re: [PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed
Date: Tue, 10 Sep 2019 22:14:12 -0400 [thread overview]
Message-ID: <yq17e6ffukr.fsf@oracle.com> (raw)
In-Reply-To: <20190905181903.29756-1-mlupfer@ddn.com> (Matt Lupfer's message of "Thu, 5 Sep 2019 18:19:28 +0000")
Matt,
> The event handler calls scsi_scan_host() when events are missed, which
> will hotplug new LUNs. However, this function won't remove any
> unplugged LUNs. The result is that hotunplug doesn't work properly
> when the number of unplugged LUNs exceeds the event queue size
> (currently 8).
>
> Scan existing LUNs when events are missed to check if they are still
> present. If not, remove them.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-09-11 2:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 18:19 [PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed Matt Lupfer
2019-09-06 8:54 ` Stefan Hajnoczi
2019-09-06 8:54 ` Stefan Hajnoczi
2019-09-09 16:55 ` Paolo Bonzini
2019-09-09 16:55 ` Paolo Bonzini
2019-09-11 2:14 ` Martin K. Petersen [this message]
2019-09-11 2:14 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17e6ffukr.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=jasowang@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mlupfer@ddn.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.