From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: james.smart@broadcom.com, dick.kennedy@broadcom.com,
jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH -next] scsi: lpfc: Remove unnecessary null check before kfree
Date: Tue, 16 Jul 2019 22:46:09 -0400 [thread overview]
Message-ID: <yq17e8hz8cu.fsf@oracle.com> (raw)
In-Reply-To: <20190711141037.57880-1-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Thu, 11 Jul 2019 22:10:37 +0800")
YueHaibing,
> A null check before a kfree is redundant, so remove it.
> This is detected by coccinelle.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <james.smart@broadcom.com>, <dick.kennedy@broadcom.com>,
<jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH -next] scsi: lpfc: Remove unnecessary null check before kfree
Date: Tue, 16 Jul 2019 22:46:09 -0400 [thread overview]
Message-ID: <yq17e8hz8cu.fsf@oracle.com> (raw)
In-Reply-To: <20190711141037.57880-1-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Thu, 11 Jul 2019 22:10:37 +0800")
YueHaibing,
> A null check before a kfree is redundant, so remove it.
> This is detected by coccinelle.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-07-17 2:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 14:10 [PATCH -next] scsi: lpfc: Remove unnecessary null check before kfree YueHaibing
2019-07-11 14:10 ` YueHaibing
2019-07-15 14:51 ` James Smart
2019-07-17 2:46 ` Martin K. Petersen [this message]
2019-07-17 2:46 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17e8hz8cu.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.