All of lore.kernel.org
 help / color / mirror / Atom feed
From: martin.petersen@oracle.com (Martin K. Petersen)
Subject: [PATCH 0/3] Provide more fine grained control over multipathing
Date: Thu, 31 May 2018 22:40:41 -0400	[thread overview]
Message-ID: <yq17enjut3q.fsf@oracle.com> (raw)
In-Reply-To: <20180531181757.GB11848@redhat.com> (Mike Snitzer's message of "Thu, 31 May 2018 14:17:57 -0400")


Mike,

> 1) container A is tasked with managing some dedicated NVMe technology
> that absolutely needs native NVMe multipath.

> 2) container B is tasked with offering some canned layered product
> that was developed ontop of dm-multipath with its own multipath-tools
> oriented APIs, etc. And it is to manage some other NVMe technology on
> the same host as container A.

This assumes there is something to manage. And that the administrative
model currently employed by DM multipath will be easily applicable to
ANA devices. I don't believe that's the case. The configuration happens
on the storage side, not on the host.

With ALUA (and the proprietary implementations that predated the spec),
it was very fuzzy whether it was the host or the target that owned
responsibility for this or that. Part of the reason was that ALUA was
deliberately vague to accommodate everybody's existing, non-standards
compliant multipath storage implementations.

With ANA the heavy burden falls entirely on the storage. Most of the
things you would currently configure in multipath.conf have no meaning
in the context of ANA. Things that are currently the domain of
dm-multipath or multipathd are inextricably living either in the storage
device or in the NVMe ANA "device handler". And I think you are
significantly underestimating the effort required to expose that
information up the stack and to make use of it. That's not just a
multipath personality toggle switch.

If you want to make multipath -ll show something meaningful for ANA
devices, then by all means go ahead. I don't have any problem with
that. But I don't think the burden of allowing multipathd/DM to inject
themselves into the path transition state machine has any benefit
whatsoever to the user. It's only complicating things and therefore we'd
be doing people a disservice rather than a favor.

-- 
Martin K. Petersen	Oracle Linux Engineering

WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	Keith Busch <keith.busch@intel.com>,
	Hannes Reinecke <hare@suse.de>,
	Laurence Oberman <loberman@redhat.com>,
	Ewan Milne <emilne@redhat.com>,
	James Smart <james.smart@broadcom.com>,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
	Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Martin George <marting@netapp.com>,
	John Meneghini <John.Meneghini@netapp.com>,
	axboe@kernel.dk
Subject: Re: [PATCH 0/3] Provide more fine grained control over multipathing
Date: Thu, 31 May 2018 22:40:41 -0400	[thread overview]
Message-ID: <yq17enjut3q.fsf@oracle.com> (raw)
In-Reply-To: <20180531181757.GB11848@redhat.com> (Mike Snitzer's message of "Thu, 31 May 2018 14:17:57 -0400")


Mike,

> 1) container A is tasked with managing some dedicated NVMe technology
> that absolutely needs native NVMe multipath.

> 2) container B is tasked with offering some canned layered product
> that was developed ontop of dm-multipath with its own multipath-tools
> oriented APIs, etc. And it is to manage some other NVMe technology on
> the same host as container A.

This assumes there is something to manage. And that the administrative
model currently employed by DM multipath will be easily applicable to
ANA devices. I don't believe that's the case. The configuration happens
on the storage side, not on the host.

With ALUA (and the proprietary implementations that predated the spec),
it was very fuzzy whether it was the host or the target that owned
responsibility for this or that. Part of the reason was that ALUA was
deliberately vague to accommodate everybody's existing, non-standards
compliant multipath storage implementations.

With ANA the heavy burden falls entirely on the storage. Most of the
things you would currently configure in multipath.conf have no meaning
in the context of ANA. Things that are currently the domain of
dm-multipath or multipathd are inextricably living either in the storage
device or in the NVMe ANA "device handler". And I think you are
significantly underestimating the effort required to expose that
information up the stack and to make use of it. That's not just a
multipath personality toggle switch.

If you want to make multipath -ll show something meaningful for ANA
devices, then by all means go ahead. I don't have any problem with
that. But I don't think the burden of allowing multipathd/DM to inject
themselves into the path transition state machine has any benefit
whatsoever to the user. It's only complicating things and therefore we'd
be doing people a disservice rather than a favor.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2018-06-01  2:40 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-25 12:53 [PATCH 0/3] Provide more fine grained control over multipathing Johannes Thumshirn
2018-05-25 12:53 ` Johannes Thumshirn
2018-05-25 12:53 ` [PATCH 1/3] nvme: provide a way to disable nvme mpath per subsystem Johannes Thumshirn
2018-05-25 12:53   ` Johannes Thumshirn
2018-05-25 13:47   ` Mike Snitzer
2018-05-25 13:47     ` Mike Snitzer
2018-05-31  8:17   ` Sagi Grimberg
2018-05-31  8:17     ` Sagi Grimberg
2018-05-25 12:53 ` [PATCH 2/3] nvme multipath: added SUBSYS_ATTR_RW Johannes Thumshirn
2018-05-25 12:53   ` Johannes Thumshirn
2018-05-25 12:53 ` [PATCH 3/3] nvme multipath: add dev_attr_mpath_personality Johannes Thumshirn
2018-05-25 12:53   ` Johannes Thumshirn
2018-05-25 13:05 ` [PATCH 0/3] Provide more fine grained control over multipathing Christoph Hellwig
2018-05-25 13:05   ` Christoph Hellwig
2018-05-25 13:58   ` Mike Snitzer
2018-05-25 13:58     ` Mike Snitzer
2018-05-25 14:12     ` Christoph Hellwig
2018-05-25 14:12       ` Christoph Hellwig
2018-05-25 14:50       ` Mike Snitzer
2018-05-25 14:50         ` Mike Snitzer
2018-05-29  1:19         ` Martin K. Petersen
2018-05-29  1:19           ` Martin K. Petersen
2018-05-29  3:02           ` Mike Snitzer
2018-05-29  3:02             ` Mike Snitzer
2018-05-29  7:18             ` Hannes Reinecke
2018-05-29  7:18               ` Hannes Reinecke
2018-05-29  7:22             ` Johannes Thumshirn
2018-05-29  7:22               ` Johannes Thumshirn
2018-05-29  8:09               ` Christoph Hellwig
2018-05-29  8:09                 ` Christoph Hellwig
2018-05-29  9:54                 ` Mike Snitzer
2018-05-29  9:54                   ` Mike Snitzer
2018-05-29 23:27                 ` Mike Snitzer
2018-05-29 23:27                   ` Mike Snitzer
2018-05-30 19:05                   ` Jens Axboe
2018-05-30 19:05                     ` Jens Axboe
2018-05-30 19:59                     ` Mike Snitzer
2018-05-30 19:59                       ` Mike Snitzer
2018-06-04  6:19                     ` Hannes Reinecke
2018-06-04  6:19                       ` Hannes Reinecke
2018-06-04  7:18                       ` Johannes Thumshirn
2018-06-04  7:18                         ` Johannes Thumshirn
2018-06-04 12:59                         ` Christoph Hellwig
2018-06-04 12:59                           ` Christoph Hellwig
2018-06-04 13:27                           ` Mike Snitzer
2018-06-04 13:27                             ` Mike Snitzer
2018-05-31  2:42               ` Ming Lei
2018-05-31  2:42                 ` Ming Lei
2018-05-30 21:20     ` Sagi Grimberg
2018-05-30 21:20       ` Sagi Grimberg
2018-05-30 22:02       ` Mike Snitzer
2018-05-30 22:02         ` Mike Snitzer
2018-05-31  8:37         ` Sagi Grimberg
2018-05-31  8:37           ` Sagi Grimberg
2018-05-31 12:37           ` Mike Snitzer
2018-05-31 12:37             ` Mike Snitzer
2018-05-31 16:34             ` Christoph Hellwig
2018-05-31 16:34               ` Christoph Hellwig
2018-06-01  4:11               ` Mike Snitzer
2018-06-01  4:11                 ` Mike Snitzer
2018-05-31 16:36           ` Christoph Hellwig
2018-05-31 16:36             ` Christoph Hellwig
2018-05-31 16:33         ` Christoph Hellwig
2018-05-31 16:33           ` Christoph Hellwig
2018-05-31 18:17           ` Mike Snitzer
2018-05-31 18:17             ` Mike Snitzer
2018-06-01  2:40             ` Martin K. Petersen [this message]
2018-06-01  2:40               ` Martin K. Petersen
2018-06-01  4:24               ` Mike Snitzer
2018-06-01  4:24                 ` Mike Snitzer
2018-06-01 14:09                 ` Martin K. Petersen
2018-06-01 14:09                   ` Martin K. Petersen
2018-06-01 15:21                   ` Mike Snitzer
2018-06-01 15:21                     ` Mike Snitzer
2018-06-03 11:00                 ` Sagi Grimberg
2018-06-03 11:00                   ` Sagi Grimberg
2018-06-03 16:06                   ` Mike Snitzer
2018-06-03 16:06                     ` Mike Snitzer
2018-06-04 11:46                     ` Sagi Grimberg
2018-06-04 11:46                       ` Sagi Grimberg
2018-06-04 12:48                       ` Johannes Thumshirn
2018-06-04 12:48                         ` Johannes Thumshirn
2018-05-30 22:44       ` Mike Snitzer
2018-05-30 22:44         ` Mike Snitzer
2018-05-31  8:51         ` Sagi Grimberg
2018-05-31  8:51           ` Sagi Grimberg
2018-05-31 12:41           ` Mike Snitzer
2018-05-31 12:41             ` Mike Snitzer
2018-06-04 21:58       ` Roland Dreier
2018-06-04 21:58         ` Roland Dreier
2018-06-05  4:42         ` Christoph Hellwig
2018-06-05  4:42           ` Christoph Hellwig
2018-06-05 22:57           ` Roland Dreier
2018-06-05 22:57             ` Roland Dreier
2018-06-06  9:51             ` Christoph Hellwig
2018-06-06  9:51               ` Christoph Hellwig
2018-06-06  9:32           ` Sagi Grimberg
2018-06-06  9:32             ` Sagi Grimberg
2018-06-06  9:50             ` Christoph Hellwig
2018-06-06  9:50               ` Christoph Hellwig
2018-05-25 14:22   ` Johannes Thumshirn
2018-05-25 14:22     ` Johannes Thumshirn
2018-05-25 14:30     ` Christoph Hellwig
2018-05-25 14:30       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq17enjut3q.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.