From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: wd719x: make card_types static const, shrinks object size
Date: Wed, 29 Nov 2017 05:12:34 +0000 [thread overview]
Message-ID: <yq17eu9hdml.fsf@oracle.com> (raw)
In-Reply-To: <20171128181234.24330-1-colin.king@canonical.com> (Colin King's message of "Tue, 28 Nov 2017 18:12:34 +0000")
Colin,
> Don't populate the read-only array card_types on the stack but instead
> make it static and constify it. Makes the object code smaller by over
> 110 bytes:
Applied to 4.16/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: wd719x: make card_types static const, shrinks object size
Date: Wed, 29 Nov 2017 00:12:34 -0500 [thread overview]
Message-ID: <yq17eu9hdml.fsf@oracle.com> (raw)
In-Reply-To: <20171128181234.24330-1-colin.king@canonical.com> (Colin King's message of "Tue, 28 Nov 2017 18:12:34 +0000")
Colin,
> Don't populate the read-only array card_types on the stack but instead
> make it static and constify it. Makes the object code smaller by over
> 110 bytes:
Applied to 4.16/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-11-29 5:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 18:12 [PATCH] scsi: wd719x: make card_types static const, shrinks object size Colin King
2017-11-29 5:12 ` Martin K. Petersen [this message]
2017-11-29 5:12 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17eu9hdml.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.