From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Max Gurtovoy <maxg@mellanox.com>,
linux-block@vger.kernel.org, martin.petersen@oracle.com,
linux-nvme@lists.infradead.org, keith.busch@intel.com,
hch@lst.de, sagi@grimberg.me, shlomin@mellanox.com,
israelr@mellanox.com
Subject: Re: [PATCH v5 2/2] block: centralize PI remapping logic to the block layer
Date: Fri, 13 Sep 2019 18:31:21 -0400 [thread overview]
Message-ID: <yq18sqrde12.fsf@oracle.com> (raw)
In-Reply-To: <380932df-2119-ad86-8bb2-3eccb005c949@kernel.dk> (Jens Axboe's message of "Wed, 11 Sep 2019 16:01:11 -0600")
Jens,
> While I like the idea of centralizing stuff like this, I'm also not
> happy with adding checks like this to the fast path.
Yeah, but at least it's just checking a request queue flag.
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: keith.busch@intel.com, sagi@grimberg.me,
martin.petersen@oracle.com, israelr@mellanox.com,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
shlomin@mellanox.com, Max Gurtovoy <maxg@mellanox.com>,
hch@lst.de
Subject: Re: [PATCH v5 2/2] block: centralize PI remapping logic to the block layer
Date: Fri, 13 Sep 2019 18:31:21 -0400 [thread overview]
Message-ID: <yq18sqrde12.fsf@oracle.com> (raw)
In-Reply-To: <380932df-2119-ad86-8bb2-3eccb005c949@kernel.dk> (Jens Axboe's message of "Wed, 11 Sep 2019 16:01:11 -0600")
Jens,
> While I like the idea of centralizing stuff like this, I'm also not
> happy with adding checks like this to the fast path.
Yeah, but at least it's just checking a request queue flag.
--
Martin K. Petersen Oracle Linux Engineering
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-13 22:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 15:23 [PATCH v5 1/2] block: use symbolic constants for t10_pi type Max Gurtovoy
2019-09-11 15:23 ` Max Gurtovoy
2019-09-11 15:23 ` [PATCH v5 2/2] block: centralize PI remapping logic to the block layer Max Gurtovoy
2019-09-11 15:23 ` Max Gurtovoy
2019-09-11 22:01 ` Jens Axboe
2019-09-11 22:01 ` Jens Axboe
2019-09-13 22:31 ` Martin K. Petersen [this message]
2019-09-13 22:31 ` Martin K. Petersen
2019-09-16 8:01 ` Christoph Hellwig
2019-09-16 8:01 ` Christoph Hellwig
2019-09-13 22:26 ` Martin K. Petersen
2019-09-13 22:26 ` Martin K. Petersen
2019-09-13 22:21 ` [PATCH v5 1/2] block: use symbolic constants for t10_pi type Martin K. Petersen
2019-09-13 22:21 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18sqrde12.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=israelr@mellanox.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=shlomin@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.