From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.garry@huawei.com>
Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
linuxarm@huawei.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2] scsi: sd: Make protection lookup tables static and relocate functions
Date: Tue, 08 Jan 2019 22:30:23 -0500 [thread overview]
Message-ID: <yq18szu4ieo.fsf@oracle.com> (raw)
In-Reply-To: <1546960492-218420-1-git-send-email-john.garry@huawei.com> (John Garry's message of "Tue, 8 Jan 2019 23:14:52 +0800")
John,
> Currently the protection lookup tables in sd_prot_flag_mask() and
> sd_prot_op() are declared as non-static. As such, they will be rebuilt
> for each respective function call.
>
> Optimise by making them static.
Applied to 5.1/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.garry@huawei.com>
Cc: <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>,
<linuxarm@huawei.com>, <linux-kernel@vger.kernel.org>,
<linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v2] scsi: sd: Make protection lookup tables static and relocate functions
Date: Tue, 08 Jan 2019 22:30:23 -0500 [thread overview]
Message-ID: <yq18szu4ieo.fsf@oracle.com> (raw)
In-Reply-To: <1546960492-218420-1-git-send-email-john.garry@huawei.com> (John Garry's message of "Tue, 8 Jan 2019 23:14:52 +0800")
John,
> Currently the protection lookup tables in sd_prot_flag_mask() and
> sd_prot_op() are declared as non-static. As such, they will be rebuilt
> for each respective function call.
>
> Optimise by making them static.
Applied to 5.1/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-01-09 3:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 15:14 [PATCH v2] scsi: sd: Make protection lookup tables static and relocate functions John Garry
2019-01-08 15:14 ` John Garry
2019-01-09 2:42 ` Bart Van Assche
2019-01-09 3:30 ` Martin K. Petersen [this message]
2019-01-09 3:30 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18szu4ieo.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.