From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.garry@huawei.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Janek Kotas <jank@cadence.com>,
"vinholikatti@gmail.com" <vinholikatti@gmail.com>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] scsi: ufs: Add UFS platform driver for Cadence UFS
Date: Fri, 09 Nov 2018 08:11:11 -0500 [thread overview]
Message-ID: <yq18t22wg40.fsf@oracle.com> (raw)
In-Reply-To: <c4937848-8459-1201-5ec1-2f453df15e1e@huawei.com> (John Garry's message of "Fri, 9 Nov 2018 11:51:59 +0000")
John,
> I am building your 4.21 queue today, and it seems to be broken from
> this patch:
>
> https://kernel.googlesource.com/pub/scm/linux/kernel/git/mkp/scsi/+/b3874a425510d1164fd3428ab99273c07d210d82
>
> You seemed to miss adding the c-file:
> make[3]: *** No rule to make target `drivers/scsi/ufs/cdns-pltfrm.o',
> needed by `drivers/scsi/ufs/built-in.a'. Stop
>
> Or am I missing something?
A corner case wrt. handling of new files in my pre-commit hook prevented
the .c file from getting properly committed.
Fixed up, thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.garry@huawei.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Janek Kotas <jank@cadence.com>,
"vinholikatti\@gmail.com" <vinholikatti@gmail.com>,
"jejb\@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"robh+dt\@kernel.org" <robh+dt@kernel.org>,
"mark.rutland\@arm.com" <mark.rutland@arm.com>,
"devicetree\@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi\@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] scsi: ufs: Add UFS platform driver for Cadence UFS
Date: Fri, 09 Nov 2018 08:11:11 -0500 [thread overview]
Message-ID: <yq18t22wg40.fsf@oracle.com> (raw)
In-Reply-To: <c4937848-8459-1201-5ec1-2f453df15e1e@huawei.com> (John Garry's message of "Fri, 9 Nov 2018 11:51:59 +0000")
John,
> I am building your 4.21 queue today, and it seems to be broken from
> this patch:
>
> https://kernel.googlesource.com/pub/scm/linux/kernel/git/mkp/scsi/+/b3874a425510d1164fd3428ab99273c07d210d82
>
> You seemed to miss adding the c-file:
> make[3]: *** No rule to make target `drivers/scsi/ufs/cdns-pltfrm.o',
> needed by `drivers/scsi/ufs/built-in.a'. Stop
>
> Or am I missing something?
A corner case wrt. handling of new files in my pre-commit hook prevented
the .c file from getting properly committed.
Fixed up, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-11-09 13:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 13:08 [PATCH v4 2/2] scsi: ufs: Add UFS platform driver for Cadence UFS Janek Kotas
2018-11-06 13:37 ` Janek Kotas
2018-11-07 2:15 ` Martin K. Petersen
2018-11-07 2:15 ` Martin K. Petersen
2018-11-07 8:23 ` Janek Kotas
2018-11-09 2:28 ` Martin K. Petersen
2018-11-09 2:28 ` Martin K. Petersen
2018-11-09 11:51 ` John Garry
2018-11-09 13:11 ` Martin K. Petersen [this message]
2018-11-09 13:11 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18t22wg40.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=jank@cadence.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.