From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: lpfc: remove redundant null check on eqe
Date: Fri, 15 Sep 2017 19:39:48 +0000 [thread overview]
Message-ID: <yq18thfpx8b.fsf@oracle.com> (raw)
In-Reply-To: <20170908080201.9592-1-colin.king@canonical.com> (Colin King's message of "Fri, 8 Sep 2017 09:02:01 +0100")
Colin,
> The pointer eqe is always non-null inside the while loop, so the check
> to see if eqe is NULL is redudant and hence can be removed.
Applied to 4.15/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: lpfc: remove redundant null check on eqe
Date: Fri, 15 Sep 2017 15:39:48 -0400 [thread overview]
Message-ID: <yq18thfpx8b.fsf@oracle.com> (raw)
In-Reply-To: <20170908080201.9592-1-colin.king@canonical.com> (Colin King's message of "Fri, 8 Sep 2017 09:02:01 +0100")
Colin,
> The pointer eqe is always non-null inside the while loop, so the check
> to see if eqe is NULL is redudant and hence can be removed.
Applied to 4.15/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-09-15 19:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 8:02 [PATCH] scsi: lpfc: remove redundant null check on eqe Colin King
2017-09-08 8:02 ` Colin King
2017-09-14 14:47 ` James Smart
2017-09-14 14:47 ` James Smart
2017-09-15 19:39 ` Martin K. Petersen [this message]
2017-09-15 19:39 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18thfpx8b.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=colin.king@canonical.com \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.