From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Doug Gilbert <dgilbert@interlog.com>,
Hannes Reinecke <hare@suse.de>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: sg: off by one in sg_ioctl()
Date: Wed, 23 Aug 2017 02:24:14 +0000 [thread overview]
Message-ID: <yq18tibaunl.fsf@oracle.com> (raw)
In-Reply-To: <20170817070954.d4gg7hqgg2qjf6d3@mwanda> (Dan Carpenter's message of "Thu, 17 Aug 2017 10:09:54 +0300")
Dan,
> If "val" is SG_MAX_QUEUE then we are one element beyond the end of the
> "rinfo" array so the > should be >=.
Applied to 4.13/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Doug Gilbert <dgilbert@interlog.com>,
Hannes Reinecke <hare@suse.de>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: sg: off by one in sg_ioctl()
Date: Tue, 22 Aug 2017 22:24:14 -0400 [thread overview]
Message-ID: <yq18tibaunl.fsf@oracle.com> (raw)
In-Reply-To: <20170817070954.d4gg7hqgg2qjf6d3@mwanda> (Dan Carpenter's message of "Thu, 17 Aug 2017 10:09:54 +0300")
Dan,
> If "val" is SG_MAX_QUEUE then we are one element beyond the end of the
> "rinfo" array so the > should be >=.
Applied to 4.13/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-08-23 2:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 7:09 [PATCH] scsi: sg: off by one in sg_ioctl() Dan Carpenter
2017-08-17 7:09 ` Dan Carpenter
2017-08-23 1:50 ` Douglas Gilbert
2017-08-23 1:50 ` Douglas Gilbert
2017-08-23 2:24 ` Martin K. Petersen [this message]
2017-08-23 2:24 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18tibaunl.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=dgilbert@interlog.com \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.