From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: kys@linuxonhyperv.com
Cc: hch@infradead.org, Stephen Hemminger <sthemmin@microsoft.com>,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
gregkh@linuxfoundation.org, jasowang@redhat.com,
ohering@suse.com, stable@vger.kernel.org,
linux-kernel@vger.kernel.org,
James.Bottomley@HansenPartnership.com,
Haiyang Zhang <haiyangz@microsoft.com>,
hare@suse.de, apw@canonical.com, devel@linuxdriverproject.org,
vkuznets@redhat.com
Subject: Re: [PATCH] scsi: storvsc: Fix a race in sub-channel creation that can cause panic
Date: Wed, 28 Nov 2018 21:34:03 -0500 [thread overview]
Message-ID: <yq1a7ls1ujo.fsf@oracle.com> (raw)
In-Reply-To: <20181126002617.7398-1-kys@linuxonhyperv.com> (kys@linuxonhyperv.com's message of "Mon, 26 Nov 2018 00:26:17 +0000")
KY,
> From: Dexuan Cui <decui@microsoft.com>
>
> We can concurrently try to open the same sub-channel from 2 paths:
>
> path #1: vmbus_onoffer() -> vmbus_process_offer() -> handle_sc_creation().
> path #2: storvsc_probe() -> storvsc_connect_to_vsp() ->
> -> storvsc_channel_init() -> handle_multichannel_storage() ->
> -> vmbus_are_subchannels_present() -> handle_sc_creation().
>
> They conflict with each other, but it was not an issue before the recent
> commit ae6935ed7d42 ("vmbus: split ring buffer allocation from open"),
> because at the beginning of vmbus_open() we checked newchannel->state so
> only one path could succeed, and the other would return with -EINVAL.
Applied to 4.20/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: kys@linuxonhyperv.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, ohering@suse.com,
James.Bottomley@HansenPartnership.com, hch@infradead.org,
linux-scsi@vger.kernel.org, apw@canonical.com,
vkuznets@redhat.com, jasowang@redhat.com,
martin.petersen@oracle.com, hare@suse.de, kys@microsoft.com,
Dexuan Cui <decui@microsoft.com>,
stable@vger.kernel.org, Long Li <longli@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>
Subject: Re: [PATCH] scsi: storvsc: Fix a race in sub-channel creation that can cause panic
Date: Wed, 28 Nov 2018 21:34:03 -0500 [thread overview]
Message-ID: <yq1a7ls1ujo.fsf@oracle.com> (raw)
In-Reply-To: <20181126002617.7398-1-kys@linuxonhyperv.com> (kys@linuxonhyperv.com's message of "Mon, 26 Nov 2018 00:26:17 +0000")
KY,
> From: Dexuan Cui <decui@microsoft.com>
>
> We can concurrently try to open the same sub-channel from 2 paths:
>
> path #1: vmbus_onoffer() -> vmbus_process_offer() -> handle_sc_creation().
> path #2: storvsc_probe() -> storvsc_connect_to_vsp() ->
> -> storvsc_channel_init() -> handle_multichannel_storage() ->
> -> vmbus_are_subchannels_present() -> handle_sc_creation().
>
> They conflict with each other, but it was not an issue before the recent
> commit ae6935ed7d42 ("vmbus: split ring buffer allocation from open"),
> because at the beginning of vmbus_open() we checked newchannel->state so
> only one path could succeed, and the other would return with -EINVAL.
Applied to 4.20/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-11-29 2:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 0:26 [PATCH] scsi: storvsc: Fix a race in sub-channel creation that can cause panic kys
2018-11-26 5:39 ` Sasha Levin
2018-11-29 2:34 ` Martin K. Petersen [this message]
2018-11-29 2:34 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1a7ls1ujo.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=kys@linuxonhyperv.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ohering@suse.com \
--cc=stable@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.