[PATCH 0/2] qla2xxx: fixes for the driver

[PATCH 0/2] qla2xxx: fixes for the driver

[Himanshu Madhani]

Hi Martin, 

This series has small fixes for the driver. 

Please apply to 4.16/scsi-queue.

Thanks,
Himanshu

Himanshu Madhani (2):
  qla2xxx: Fix warning reported for req_que_no in qla24xx_async_cmd()
  qla2xxx: Fix logo flag for qlt_free_session_done()

 drivers/scsi/qla2xxx/qla_init.c   | 5 +++--
 drivers/scsi/qla2xxx/qla_target.c | 1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

-- 
2.12.0

[PATCH 1/2] qla2xxx: Fix warning reported for req_que_no in qla24xx_async_cmd()

[Himanshu Madhani]

This patch fixes following sparse warning

drivers/scsi/qla2xxx/qla_init.c:1570:44: sparse: incorrect type in assignment
(different base types)

Fixes: 07a21872cf2b ("scsi: qla2xxx: Fix queue ID for async abort with Multiqueue")
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
---
 drivers/scsi/qla2xxx/qla_init.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 27e67f7ae18a..5b6f3c53fdcf 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -1567,9 +1567,10 @@ qla24xx_async_abort_cmd(srb_t *cmd_sp)
 	abt_iocb->u.abt.cmd_hndl = cmd_sp->handle;
 
 	if (vha->flags.qpairs_available && cmd_sp->qpair)
-		abt_iocb->u.abt.req_que_no = cmd_sp->qpair->req->id;
+		abt_iocb->u.abt.req_que_no =
+		    cpu_to_le16(cmd_sp->qpair->req->id);
 	else
-		abt_iocb->u.abt.req_que_no = vha->req->id;
+		abt_iocb->u.abt.req_que_no = cpu_to_le16(vha->req->id);
 
 	sp->done = qla24xx_abort_sp_done;
 	abt_iocb->timeout = qla24xx_abort_iocb_timeout;
-- 
2.12.0

Re: [PATCH 1/2] qla2xxx: Fix warning reported for req_que_no in qla24xx_async_cmd()

[Martin K. Petersen]

Himanshu,

> This patch fixes following sparse warning
>
> drivers/scsi/qla2xxx/qla_init.c:1570:44: sparse: incorrect type in assignment
> (different base types)

Amended the original commit. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

[PATCH 2/2] qla2xxx: Fix logo flag for qlt_free_session_done()

[Himanshu Madhani]

From: Himanshu Madhani <hmadhani@redhat.com>

Commit 3515832cc61467bfb87191a30401de1700e9956a fixed the target
re-login after session relogin is complete, but missed out the
qlt_free_session_done() path.

This patch clears send_els_logo flag in qlt_free_session_done() callback.

Fixes: 3515832cc614 ("scsi: qla2xxx: Reset the logo flag, after target re-login.")
Signed-off-by: Himanshu Madhani <hmadhani@redhat.com>
---
 drivers/scsi/qla2xxx/qla_target.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index dd8edae4c152..14359656591e 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -988,6 +988,7 @@ void qlt_free_session_done(struct work_struct *work)
 
 			logo.id = sess->d_id;
 			logo.cmd_count = 0;
+			sess->send_els_logo = 0;
 			qlt_send_first_logo(vha, &logo);
 		}
 
-- 
2.12.0

Re: [PATCH 2/2] qla2xxx: Fix logo flag for qlt_free_session_done()

[Martin K. Petersen]

Himanshu,

> Commit 3515832cc61467bfb87191a30401de1700e9956a fixed the target
> re-login after session relogin is complete, but missed out the
> qlt_free_session_done() path.
>
> This patch clears send_els_logo flag in qlt_free_session_done() callback.

Applied to 4.16/scsi-queue. And please run checkpatch before sending.

-- 
Martin K. Petersen	Oracle Linux Engineering