All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi, block: fix memory leak of sdpk on when gd fails to allocate
Date: Thu, 23 Feb 2017 00:19:02 +0000	[thread overview]
Message-ID: <yq1a89d92tl.fsf@oracle.com> (raw)
In-Reply-To: <20170203193854.6782-1-colin.king@canonical.com> (Colin King's message of "Fri, 3 Feb 2017 19:38:54 +0000")

>>>>> "Colin" = Colin King <colin.king@canonical.com> writes:

Colin> On an allocation failure of gd, the current exit path is via
Colin> out_free_devt which leaves sdpk still allocated and hence it gets
Colin> leaked. Fix this by correcting the order of resource free'ing
Colin> with a change in the error exit path labels.

Applied to 4.11/scsi-fixes.

-- 
Martin K. Petersen	Oracle Linux Engineering

WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi, block: fix memory leak of sdpk on when gd fails to allocate
Date: Wed, 22 Feb 2017 19:19:02 -0500	[thread overview]
Message-ID: <yq1a89d92tl.fsf@oracle.com> (raw)
In-Reply-To: <20170203193854.6782-1-colin.king@canonical.com> (Colin King's message of "Fri, 3 Feb 2017 19:38:54 +0000")

>>>>> "Colin" == Colin King <colin.king@canonical.com> writes:

Colin> On an allocation failure of gd, the current exit path is via
Colin> out_free_devt which leaves sdpk still allocated and hence it gets
Colin> leaked. Fix this by correcting the order of resource free'ing
Colin> with a change in the error exit path labels.

Applied to 4.11/scsi-fixes.

-- 
Martin K. Petersen	Oracle Linux Engineering

  parent reply	other threads:[~2017-02-23  0:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-03 19:38 [PATCH] scsi, block: fix memory leak of sdpk on when gd fails to allocate Colin King
2017-02-03 19:38 ` Colin King
2017-02-15 18:03 ` Bart Van Assche
2017-02-23  0:19 ` Martin K. Petersen [this message]
2017-02-23  0:19   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1a89d92tl.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=colin.king@canonical.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.