All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <mkp@wildopensource.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
	akpm@osdl.org, tony.luck@intel.com
Subject: Re: [PATCH] General purpose zeroed page slab
Date: Mon, 18 Oct 2004 18:54:13 +0000	[thread overview]
Message-ID: <yq1acujrh62.fsf@wilson.mkp.net> (raw)
In-Reply-To: <20041018184210.GI16153@parcelfarce.linux.theplanet.co.uk> (Matthew Wilcox's message of "Mon, 18 Oct 2004 19:42:10 +0100")

>>>>> "Matthew" = Matthew Wilcox <matthew@wil.cx> writes:

Matthew> It's probably worth doing this with a static cachep in slab.c
Matthew> and only exposing a get_zeroed_page() / free_zeroed_page()
Matthew> interface, with the latter doing the memset to 0.  

*nod*


Matthew> I disagree with Andi over the dumbness of zeroing the whole
Matthew> page.  That makes it cache-hot, which is what you want from a
Matthew> page you allocate from slab.

Yeah, plus the housekeeping may be more of a hassle than it's worth.

We'll see...

-- 
Martin K. Petersen	Wild Open Source, Inc.
mkp@wildopensource.com	http://www.wildopensource.com/

WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <mkp@wildopensource.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
	akpm@osdl.org, tony.luck@intel.com
Subject: Re: [PATCH] General purpose zeroed page slab
Date: Mon, 18 Oct 2004 14:54:13 -0400	[thread overview]
Message-ID: <yq1acujrh62.fsf@wilson.mkp.net> (raw)
In-Reply-To: <20041018184210.GI16153@parcelfarce.linux.theplanet.co.uk> (Matthew Wilcox's message of "Mon, 18 Oct 2004 19:42:10 +0100")

>>>>> "Matthew" == Matthew Wilcox <matthew@wil.cx> writes:

Matthew> It's probably worth doing this with a static cachep in slab.c
Matthew> and only exposing a get_zeroed_page() / free_zeroed_page()
Matthew> interface, with the latter doing the memset to 0.  

*nod*


Matthew> I disagree with Andi over the dumbness of zeroing the whole
Matthew> page.  That makes it cache-hot, which is what you want from a
Matthew> page you allocate from slab.

Yeah, plus the housekeeping may be more of a hassle than it's worth.

We'll see...

-- 
Martin K. Petersen	Wild Open Source, Inc.
mkp@wildopensource.com	http://www.wildopensource.com/

  reply	other threads:[~2004-10-18 18:54 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-14 16:50 [PATCH] General purpose zeroed page slab Martin K. Petersen
2004-10-14 16:50 ` Martin K. Petersen
2004-10-14 17:30 ` Brian Gerst
2004-10-14 17:30   ` Brian Gerst
2004-10-14 17:36   ` Matthew Wilcox
2004-10-14 17:36     ` Matthew Wilcox
2004-10-14 18:49     ` Dave Jones
2004-10-14 18:49       ` Dave Jones
2004-10-14 19:08       ` Denis Vlasenko
2004-10-14 19:08         ` Denis Vlasenko
2004-10-14 19:47         ` Matthew Wilcox
2004-10-14 19:47           ` Matthew Wilcox
2004-10-14 18:04 ` Andi Kleen
2004-10-14 18:04   ` Andi Kleen
2004-10-14 23:36   ` Adam Heath
2004-10-14 23:36     ` Adam Heath
2004-10-15  1:18     ` Andi Kleen
2004-10-15  1:18       ` Andi Kleen
2004-10-18 18:06   ` Martin K. Petersen
2004-10-18 18:06     ` Martin K. Petersen
2004-10-18 18:42     ` Matthew Wilcox
2004-10-18 18:42       ` Matthew Wilcox
2004-10-18 18:54       ` Martin K. Petersen [this message]
2004-10-18 18:54         ` Martin K. Petersen
2004-10-18 19:06       ` Andi Kleen
2004-10-18 19:06         ` Andi Kleen
2004-10-18 21:06       ` Andi Kleen
2004-10-18 21:06         ` Andi Kleen
2004-10-18 19:03 ` Luck, Tony
2004-10-18 19:03   ` Luck, Tony
2004-10-18 19:14   ` Matthew Wilcox
2004-10-18 19:14     ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1acujrh62.fsf@wilson.mkp.net \
    --to=mkp@wildopensource.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.