From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
Saurav Kashyap <skashyap@marvell.com>
Subject: Re: [PATCH v2] scsi: qedf: Simplify mutex_unlock() usage
Date: Mon, 13 Apr 2020 21:16:14 -0400 [thread overview]
Message-ID: <yq1blnuvpcx.fsf@oracle.com> (raw)
In-Reply-To: <20200403092717.19779-1-dwagner@suse.de> (Daniel Wagner's message of "Fri, 3 Apr 2020 11:27:17 +0200")
Daniel,
> The commit 6d1368e8f987 ("scsi: qedf: fixup locking in
> qedf_restart_rport()") introduced the lock. Though the lock protects
> only the fc_rport_create() call. Thus, we can move the mutex unlock up
> before the if statement and drop the else body.
Applied to 5.8/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2020-04-14 1:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 9:27 [PATCH v2] scsi: qedf: Simplify mutex_unlock() usage Daniel Wagner
2020-04-14 1:16 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1blnuvpcx.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=dwagner@suse.de \
--cc=hare@suse.com \
--cc=linux-scsi@vger.kernel.org \
--cc=skashyap@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.