All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Long Li <longli@linuxonhyperv.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
	linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	"James E . J . Bottomley" <JBottomley@odin.com>,
	linux-kernel@vger.kernel.org, devel@linuxdriverproject.org
Subject: Re: [Patch v2] Storvsc: Select channel based on available percentage of ring buffer to write
Date: Fri, 20 Apr 2018 15:40:11 -0400	[thread overview]
Message-ID: <yq1bmedis4k.fsf@oracle.com> (raw)
In-Reply-To: <20180419215424.3557-1-longli@linuxonhyperv.com> (Long Li's message of "Thu, 19 Apr 2018 14:54:24 -0700")


Long,

> This is a best effort for estimating on how busy the ring buffer is
> for that channel, based on available buffer to write in percentage. It
> is still possible that at the time of actual ring buffer write, the
> space may not be available due to other processes may be writing at
> the time.
>
> Selecting a channel based on how full it is can reduce the possibility
> that a ring buffer write will fail, and avoid the situation a channel
> is over busy.
>
> Now it's possible that storvsc can use a smaller ring buffer size
> (e.g. 40k bytes) to take advantage of cache locality.

Applied to 4.18/scsi-queue. Thank you!

-- 
Martin K. Petersen	Oracle Linux Engineering

WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Long Li <longli@linuxonhyperv.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
	linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	"James E . J . Bottomley" <JBottomley@odin.com>,
	linux-kernel@vger.kernel.org, devel@linuxdriverproject.org
Subject: Re: [Patch v2] Storvsc: Select channel based on available percentage of ring buffer to write
Date: Fri, 20 Apr 2018 15:40:11 -0400	[thread overview]
Message-ID: <yq1bmedis4k.fsf@oracle.com> (raw)
In-Reply-To: <20180419215424.3557-1-longli@linuxonhyperv.com> (Long Li's message of "Thu, 19 Apr 2018 14:54:24 -0700")


Long,

> This is a best effort for estimating on how busy the ring buffer is
> for that channel, based on available buffer to write in percentage. It
> is still possible that at the time of actual ring buffer write, the
> space may not be available due to other processes may be writing at
> the time.
>
> Selecting a channel based on how full it is can reduce the possibility
> that a ring buffer write will fail, and avoid the situation a channel
> is over busy.
>
> Now it's possible that storvsc can use a smaller ring buffer size
> (e.g. 40k bytes) to take advantage of cache locality.

Applied to 4.18/scsi-queue. Thank you!

-- 
Martin K. Petersen	Oracle Linux Engineering
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2018-04-20 19:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19 21:54 [Patch v2] Storvsc: Select channel based on available percentage of ring buffer to write Long Li
2018-04-19 21:54 ` Long Li
2018-04-20 15:50 ` Stephen Hemminger
2018-04-20 15:50   ` Stephen Hemminger
2018-04-20 19:40 ` Martin K. Petersen [this message]
2018-04-20 19:40   ` Martin K. Petersen
2018-04-22 18:53 ` Michael Kelley (EOSG)
2018-04-22 18:53   ` Michael Kelley (EOSG)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1bmedis4k.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=JBottomley@odin.com \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=longli@linuxonhyperv.com \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.