* [PATCH -next] scsi: arcmsr: Remove set but not used variables 'id, lun'
@ 2018-10-12 10:36 YueHaibing
2018-10-16 22:15 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-10-12 10:36 UTC (permalink / raw)
To: kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/arcmsr/arcmsr_hba.c: In function 'arcmsr_drain_donequeue':
drivers/scsi/arcmsr/arcmsr_hba.c:1320:10: warning:
variable 'lun' set but not used [-Wunused-but-set-variable]
drivers/scsi/arcmsr/arcmsr_hba.c:1320:6: warning:
variable 'id' set but not used [-Wunused-but-set-variable]
It never used since introduction in commit ae52e7f09ff5
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/arcmsr/arcmsr_hba.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index cc0be46..f53e1bc 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -1317,13 +1317,10 @@ static void arcmsr_report_ccb_state(struct AdapterControlBlock *acb,
static void arcmsr_drain_donequeue(struct AdapterControlBlock *acb, struct CommandControlBlock *pCCB, bool error)
{
- int id, lun;
if ((pCCB->acb != acb) || (pCCB->startdone != ARCMSR_CCB_START)) {
if (pCCB->startdone = ARCMSR_CCB_ABORTED) {
struct scsi_cmnd *abortcmd = pCCB->pcmd;
if (abortcmd) {
- id = abortcmd->device->id;
- lun = abortcmd->device->lun;
abortcmd->result |= DID_ABORT << 16;
arcmsr_ccb_complete(pCCB);
printk(KERN_NOTICE "arcmsr%d: pCCB ='0x%p' isr got aborted command \n",
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] scsi: arcmsr: Remove set but not used variables 'id, lun'
2018-10-12 10:36 [PATCH -next] scsi: arcmsr: Remove set but not used variables 'id, lun' YueHaibing
@ 2018-10-16 22:15 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2018-10-16 22:15 UTC (permalink / raw)
To: kernel-janitors
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/arcmsr/arcmsr_hba.c: In function 'arcmsr_drain_donequeue':
> drivers/scsi/arcmsr/arcmsr_hba.c:1320:10: warning:
> variable 'lun' set but not used [-Wunused-but-set-variable]
>
> drivers/scsi/arcmsr/arcmsr_hba.c:1320:6: warning:
> variable 'id' set but not used [-Wunused-but-set-variable]
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-16 22:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-12 10:36 [PATCH -next] scsi: arcmsr: Remove set but not used variables 'id, lun' YueHaibing
2018-10-16 22:15 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.