From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jens Axboe <jaxboe@fusionio.com>
Cc: Xiaotian Feng <dfeng@redhat.com>, linux-scsi@vger.kernel.org
Subject: [PATCH] block: Fix double free in blk_integrity_unregister
Date: Fri, 08 Oct 2010 01:18:16 -0400 [thread overview]
Message-ID: <yq1d3rls1nr.fsf@sermon.lab.mkp.net> (raw)
Commit 3839e4b introduced a kobject_put but failed to remove the
kmem_cache_free beneath it, leading to a double free.
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---
diff --git a/block/blk-integrity.c b/block/blk-integrity.c
index 885cbb5..54bcba6 100644
--- a/block/blk-integrity.c
+++ b/block/blk-integrity.c
@@ -432,7 +432,6 @@ void blk_integrity_unregister(struct gendisk *disk)
kobject_uevent(&bi->kobj, KOBJ_REMOVE);
kobject_del(&bi->kobj);
kobject_put(&bi->kobj);
- kmem_cache_free(integrity_cachep, bi);
disk->integrity = NULL;
}
EXPORT_SYMBOL(blk_integrity_unregister);
reply other threads:[~2010-10-08 5:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d3rls1nr.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=dfeng@redhat.com \
--cc=jaxboe@fusionio.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.