* [PATCH] block: Fix double free in blk_integrity_unregister
@ 2010-10-08 5:18 Martin K. Petersen
0 siblings, 0 replies; only message in thread
From: Martin K. Petersen @ 2010-10-08 5:18 UTC (permalink / raw)
To: Jens Axboe; +Cc: Xiaotian Feng, linux-scsi
Commit 3839e4b introduced a kobject_put but failed to remove the
kmem_cache_free beneath it, leading to a double free.
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---
diff --git a/block/blk-integrity.c b/block/blk-integrity.c
index 885cbb5..54bcba6 100644
--- a/block/blk-integrity.c
+++ b/block/blk-integrity.c
@@ -432,7 +432,6 @@ void blk_integrity_unregister(struct gendisk *disk)
kobject_uevent(&bi->kobj, KOBJ_REMOVE);
kobject_del(&bi->kobj);
kobject_put(&bi->kobj);
- kmem_cache_free(integrity_cachep, bi);
disk->integrity = NULL;
}
EXPORT_SYMBOL(blk_integrity_unregister);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-10-08 5:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-08 5:18 [PATCH] block: Fix double free in blk_integrity_unregister Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.