* [PATCH -next] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param
@ 2018-12-20 3:16 ` YueHaibing
0 siblings, 0 replies; 5+ messages in thread
From: YueHaibing @ 2018-12-20 3:16 UTC (permalink / raw)
To: QLogic-Storage-Upstream, jejb, martin.petersen
Cc: linux-kernel, linux-scsi, YueHaibing
The return code should be check while qla4xxx_copy_from_fwddb_param
fails.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/qla4xxx/ql4_os.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index 949e186..1bc4db6 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -7232,6 +7232,8 @@ static int qla4xxx_sysfs_ddb_tgt_create(struct scsi_qla_host *ha,
rc = qla4xxx_copy_from_fwddb_param(fnode_sess, fnode_conn,
fw_ddb_entry);
+ if (rc)
+ goto free_sess;
ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n",
__func__, fnode_sess->dev.kobj.name);
--
2.7.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH -next] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param
@ 2018-12-20 3:16 ` YueHaibing
0 siblings, 0 replies; 5+ messages in thread
From: YueHaibing @ 2018-12-20 3:16 UTC (permalink / raw)
To: QLogic-Storage-Upstream, jejb, martin.petersen
Cc: linux-kernel, linux-scsi, YueHaibing
The return code should be check while qla4xxx_copy_from_fwddb_param
fails.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/qla4xxx/ql4_os.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index 949e186..1bc4db6 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -7232,6 +7232,8 @@ static int qla4xxx_sysfs_ddb_tgt_create(struct scsi_qla_host *ha,
rc = qla4xxx_copy_from_fwddb_param(fnode_sess, fnode_conn,
fw_ddb_entry);
+ if (rc)
+ goto free_sess;
ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n",
__func__, fnode_sess->dev.kobj.name);
--
2.7.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [EXT] [PATCH -next] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param
2018-12-20 3:16 ` YueHaibing
(?)
@ 2018-12-24 8:49 ` Manish Rangankar
-1 siblings, 0 replies; 5+ messages in thread
From: Manish Rangankar @ 2018-12-24 8:49 UTC (permalink / raw)
To: YueHaibing, QLogic-Storage-Upstream@qlogic.com,
jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
> -----Original Message-----
> From: YueHaibing <yuehaibing@huawei.com>
> Sent: Thursday, December 20, 2018 8:46 AM
> To: QLogic-Storage-Upstream@qlogic.com; jejb@linux.ibm.com;
> martin.petersen@oracle.com
> Cc: linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org; YueHaibing
> <yuehaibing@huawei.com>
> Subject: [EXT] [PATCH -next] scsi: qla4xxx: check return code of
> qla4xxx_copy_from_fwddb_param
>
> External Email
>
> ----------------------------------------------------------------------
> External Email
>
> The return code should be check while qla4xxx_copy_from_fwddb_param fails.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/scsi/qla4xxx/ql4_os.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index
> 949e186..1bc4db6 100644
> --- a/drivers/scsi/qla4xxx/ql4_os.c
> +++ b/drivers/scsi/qla4xxx/ql4_os.c
> @@ -7232,6 +7232,8 @@ static int qla4xxx_sysfs_ddb_tgt_create(struct
> scsi_qla_host *ha,
>
> rc = qla4xxx_copy_from_fwddb_param(fnode_sess, fnode_conn,
> fw_ddb_entry);
> + if (rc)
> + goto free_sess;
>
> ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n",
> __func__, fnode_sess->dev.kobj.name);
> --
> 2.7.0
>
Thanks
Acked-by: Manish Rangankar <mrangankar@marvell.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param
2018-12-20 3:16 ` YueHaibing
@ 2019-01-04 6:04 ` Martin K. Petersen
-1 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2019-01-04 6:04 UTC (permalink / raw)
To: YueHaibing
Cc: QLogic-Storage-Upstream, jejb, martin.petersen, linux-kernel,
linux-scsi
YueHaibing,
> The return code should be check while qla4xxx_copy_from_fwddb_param
> fails.
Applied to 4.21/scsi-fixes, thank you.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-04 6:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-20 3:16 [PATCH -next] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param YueHaibing
2018-12-20 3:16 ` YueHaibing
2018-12-24 8:49 ` [EXT] " Manish Rangankar
2019-01-04 6:04 ` Martin K. Petersen
2019-01-04 6:04 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.