[PATCH] scsi: mpi3mr: refer CONFIG_SCSI_MPI3MR in makefile

[PATCH] scsi: mpi3mr: refer CONFIG_SCSI_MPI3MR in makefile

[Shin'ichiro Kawasaki]

When kconfig item CONFIG_SCSI_MPI3MR was introduced for mpi3mr driver,
makefile of the driver was not modified to refer the kconfig item. Then
mpi3mr.ko is built regardless of the kconfig item value y or m. Also
"make localmodconfig" can not find the kconfig item in the makefile,
then it does not generate CONFIG_SCSI_MPI3MR=m even when mpi3mr.ko is
loaded on the system. Refer the kconfig item to avoid the issues.

Fixes: c4f7ac64616e ("scsi: mpi3mr: Add mpi30 Rev-R headers and Kconfig")
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
 drivers/scsi/mpi3mr/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/mpi3mr/Makefile b/drivers/scsi/mpi3mr/Makefile
index ef86ca46646b..3bf8cf34e1c3 100644
--- a/drivers/scsi/mpi3mr/Makefile
+++ b/drivers/scsi/mpi3mr/Makefile
@@ -1,5 +1,5 @@
 # mpi3mr makefile
-obj-m += mpi3mr.o
+obj-$(CONFIG_SCSI_MPI3MR) += mpi3mr.o
 mpi3mr-y +=  mpi3mr_os.o     \
 		mpi3mr_fw.o \
 		mpi3mr_app.o \
-- 
2.37.1

Re: [PATCH] scsi: mpi3mr: refer CONFIG_SCSI_MPI3MR in makefile

[Damien Le Moal]

On 2022/12/07 11:36, Shin'ichiro Kawasaki wrote:
> When kconfig item CONFIG_SCSI_MPI3MR was introduced for mpi3mr driver,
> makefile of the driver was not modified to refer the kconfig item. Then
> mpi3mr.ko is built regardless of the kconfig item value y or m. Also
> "make localmodconfig" can not find the kconfig item in the makefile,
> then it does not generate CONFIG_SCSI_MPI3MR=m even when mpi3mr.ko is
> loaded on the system. Refer the kconfig item to avoid the issues.
> 
> Fixes: c4f7ac64616e ("scsi: mpi3mr: Add mpi30 Rev-R headers and Kconfig")
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
>  drivers/scsi/mpi3mr/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/mpi3mr/Makefile b/drivers/scsi/mpi3mr/Makefile
> index ef86ca46646b..3bf8cf34e1c3 100644
> --- a/drivers/scsi/mpi3mr/Makefile
> +++ b/drivers/scsi/mpi3mr/Makefile
> @@ -1,5 +1,5 @@
>  # mpi3mr makefile
> -obj-m += mpi3mr.o
> +obj-$(CONFIG_SCSI_MPI3MR) += mpi3mr.o
>  mpi3mr-y +=  mpi3mr_os.o     \
>  		mpi3mr_fw.o \
>  		mpi3mr_app.o \

Looks good to me.

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research

Re: [PATCH] scsi: mpi3mr: refer CONFIG_SCSI_MPI3MR in makefile

[Sathya Prakash Veerichetty]

[-- Attachment #1: Type: text/plain, Size: 2243 bytes --]

On Tue, Dec 6, 2022 at 8:28 PM Damien Le Moal
<damien.lemoal@opensource.wdc.com> wrote:
>
> On 2022/12/07 11:36, Shin'ichiro Kawasaki wrote:
> > When kconfig item CONFIG_SCSI_MPI3MR was introduced for mpi3mr driver,
> > makefile of the driver was not modified to refer the kconfig item. Then
> > mpi3mr.ko is built regardless of the kconfig item value y or m. Also
> > "make localmodconfig" can not find the kconfig item in the makefile,
> > then it does not generate CONFIG_SCSI_MPI3MR=m even when mpi3mr.ko is
> > loaded on the system. Refer the kconfig item to avoid the issues.
> >
> > Fixes: c4f7ac64616e ("scsi: mpi3mr: Add mpi30 Rev-R headers and Kconfig")
> > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> > ---
> >  drivers/scsi/mpi3mr/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/scsi/mpi3mr/Makefile b/drivers/scsi/mpi3mr/Makefile
> > index ef86ca46646b..3bf8cf34e1c3 100644
> > --- a/drivers/scsi/mpi3mr/Makefile
> > +++ b/drivers/scsi/mpi3mr/Makefile
> > @@ -1,5 +1,5 @@
> >  # mpi3mr makefile
> > -obj-m += mpi3mr.o
> > +obj-$(CONFIG_SCSI_MPI3MR) += mpi3mr.o
> >  mpi3mr-y +=  mpi3mr_os.o     \
> >               mpi3mr_fw.o \
> >               mpi3mr_app.o \
>
> Looks good to me.
>
> Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>
> --
> Damien Le Moal
> Western Digital Research
>

Acked-by: Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>

-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4227 bytes --]

Re: [PATCH] scsi: mpi3mr: refer CONFIG_SCSI_MPI3MR in makefile

[Martin K. Petersen]

Shin'ichiro,

> When kconfig item CONFIG_SCSI_MPI3MR was introduced for mpi3mr driver,
> makefile of the driver was not modified to refer the kconfig item. Then
> mpi3mr.ko is built regardless of the kconfig item value y or m. Also
> "make localmodconfig" can not find the kconfig item in the makefile,
> then it does not generate CONFIG_SCSI_MPI3MR=m even when mpi3mr.ko is
> loaded on the system. Refer the kconfig item to avoid the issues.

Applied to 6.2/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering