* [PATCH] target:iscsi:free conn_ops when zalloc_cpumask_var failed
@ 2019-03-20 14:14 tangwenji
2019-03-20 16:35 ` Mike Christie
2019-03-21 0:38 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: tangwenji @ 2019-03-20 14:14 UTC (permalink / raw)
To: target-devel
From: tangwenji <tang.wenji@zte.com.cn>
It should not free cpumask but free conn->conn_ops When zalloc_cpumask_var failed.
Signed-off-by: tangwenji <tang.wenji@zte.com.cn>
---
drivers/target/iscsi/iscsi_target_login.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c
index ae3209e..c3e1d40 100644
--- a/drivers/target/iscsi/iscsi_target_login.c
+++ b/drivers/target/iscsi/iscsi_target_login.c
@@ -1159,13 +1159,13 @@ static struct iscsi_conn *iscsit_alloc_conn(struct iscsi_np *np)
if (!zalloc_cpumask_var(&conn->conn_cpumask, GFP_KERNEL)) {
pr_err("Unable to allocate conn->conn_cpumask\n");
- goto free_mask;
+ goto free_conn_ops;
}
return conn;
-free_mask:
- free_cpumask_var(conn->conn_cpumask);
+free_conn_ops:
+ kfree(conn->conn_ops);
put_transport:
iscsit_put_transport(conn->conn_transport);
free_conn:
--
2.5.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] target:iscsi:free conn_ops when zalloc_cpumask_var failed
2019-03-20 14:14 [PATCH] target:iscsi:free conn_ops when zalloc_cpumask_var failed tangwenji
@ 2019-03-20 16:35 ` Mike Christie
2019-03-21 0:38 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Mike Christie @ 2019-03-20 16:35 UTC (permalink / raw)
To: target-devel
On 03/20/2019 09:14 AM, tangwenji wrote:
> From: tangwenji <tang.wenji@zte.com.cn>
>
> It should not free cpumask but free conn->conn_ops When zalloc_cpumask_var failed.
>
> Signed-off-by: tangwenji <tang.wenji@zte.com.cn>
> ---
> drivers/target/iscsi/iscsi_target_login.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c
> index ae3209e..c3e1d40 100644
> --- a/drivers/target/iscsi/iscsi_target_login.c
> +++ b/drivers/target/iscsi/iscsi_target_login.c
> @@ -1159,13 +1159,13 @@ static struct iscsi_conn *iscsit_alloc_conn(struct iscsi_np *np)
>
> if (!zalloc_cpumask_var(&conn->conn_cpumask, GFP_KERNEL)) {
> pr_err("Unable to allocate conn->conn_cpumask\n");
> - goto free_mask;
> + goto free_conn_ops;
> }
>
> return conn;
>
> -free_mask:
> - free_cpumask_var(conn->conn_cpumask);
> +free_conn_ops:
> + kfree(conn->conn_ops);
> put_transport:
> iscsit_put_transport(conn->conn_transport);
> free_conn:
>
Reviewed-by: Mike Christie <mchristi@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target:iscsi:free conn_ops when zalloc_cpumask_var failed
2019-03-20 14:14 [PATCH] target:iscsi:free conn_ops when zalloc_cpumask_var failed tangwenji
2019-03-20 16:35 ` Mike Christie
@ 2019-03-21 0:38 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2019-03-21 0:38 UTC (permalink / raw)
To: target-devel
tangwenji,
> It should not free cpumask but free conn->conn_ops When
> zalloc_cpumask_var failed.
Applied to 5.2/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-21 0:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-20 14:14 [PATCH] target:iscsi:free conn_ops when zalloc_cpumask_var failed tangwenji
2019-03-20 16:35 ` Mike Christie
2019-03-21 0:38 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.