From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sathya Prakash <sathya.prakash@broadcom.com>,
Chaitra P B <chaitra.basappa@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mptfusion: Add bounds check in mptctl_hp_targetinfo()
Date: Wed, 31 Jan 2018 02:32:38 +0000 [thread overview]
Message-ID: <yq1fu6mg3ll.fsf@oracle.com> (raw)
In-Reply-To: <20180125142727.GA23945@mwanda> (Dan Carpenter's message of "Thu, 25 Jan 2018 17:27:27 +0300")
Dan,
> My static checker complains about an out of bounds read:
>
> drivers/message/fusion/mptctl.c:2786 mptctl_hp_targetinfo()
> error: buffer overflow 'hd->sel_timeout' 255 <= u32max.
>
> It's true that we probably should have a bounds check here.
Applied to 4.16/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sathya Prakash <sathya.prakash@broadcom.com>,
Chaitra P B <chaitra.basappa@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mptfusion: Add bounds check in mptctl_hp_targetinfo()
Date: Tue, 30 Jan 2018 21:32:38 -0500 [thread overview]
Message-ID: <yq1fu6mg3ll.fsf@oracle.com> (raw)
In-Reply-To: <20180125142727.GA23945@mwanda> (Dan Carpenter's message of "Thu, 25 Jan 2018 17:27:27 +0300")
Dan,
> My static checker complains about an out of bounds read:
>
> drivers/message/fusion/mptctl.c:2786 mptctl_hp_targetinfo()
> error: buffer overflow 'hd->sel_timeout' 255 <= u32max.
>
> It's true that we probably should have a bounds check here.
Applied to 4.16/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-01-31 2:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 14:27 [PATCH] mptfusion: Add bounds check in mptctl_hp_targetinfo() Dan Carpenter
2018-01-25 14:27 ` Dan Carpenter
2018-01-29 14:57 ` Johannes Thumshirn
2018-01-29 14:57 ` Johannes Thumshirn
2018-01-31 2:32 ` Martin K. Petersen [this message]
2018-01-31 2:32 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fu6mg3ll.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=chaitra.basappa@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sathya.prakash@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.