From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: John Garry <john.garry@huawei.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: hisi_sas: add missing break in switch statement
Date: Thu, 30 Mar 2017 02:39:52 +0000 [thread overview]
Message-ID: <yq1fuhv4hdz.fsf@oracle.com> (raw)
In-Reply-To: <20170328111222.17303-1-colin.king@canonical.com> (Colin King's message of "Tue, 28 Mar 2017 12:12:22 +0100")
Colin King <colin.king@canonical.com> writes:
Colin,
> It appears that a break in the TRANS_TX_OPEN_CNX_ERR_NO_DESTINATION
> case got accidentally removed in an earlier commit, as it stands, the
> ts->stat and ts->open_rej_reason are being updated twice for this case
> which looks incorrect. Fix this by adding in the missing break
> statement.
Applied to 4.12/scsi-queue.
Thank you!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: John Garry <john.garry@huawei.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: hisi_sas: add missing break in switch statement
Date: Wed, 29 Mar 2017 22:39:52 -0400 [thread overview]
Message-ID: <yq1fuhv4hdz.fsf@oracle.com> (raw)
In-Reply-To: <20170328111222.17303-1-colin.king@canonical.com> (Colin King's message of "Tue, 28 Mar 2017 12:12:22 +0100")
Colin King <colin.king@canonical.com> writes:
Colin,
> It appears that a break in the TRANS_TX_OPEN_CNX_ERR_NO_DESTINATION
> case got accidentally removed in an earlier commit, as it stands, the
> ts->stat and ts->open_rej_reason are being updated twice for this case
> which looks incorrect. Fix this by adding in the missing break
> statement.
Applied to 4.12/scsi-queue.
Thank you!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-03-30 2:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 11:12 [PATCH] scsi: hisi_sas: add missing break in switch statement Colin King
2017-03-28 11:12 ` Colin King
2017-03-28 11:42 ` John Garry
2017-03-28 11:42 ` John Garry
2017-03-28 11:42 ` John Garry
2017-03-30 2:39 ` Martin K. Petersen [this message]
2017-03-30 2:39 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fuhv4hdz.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.