From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"axboe@fb.com" <axboe@fb.com>, "hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH v2 10/12] block: move blk_integrity to request_queue
Date: Mon, 19 Oct 2015 22:24:27 -0400 [thread overview]
Message-ID: <yq1fv16gtus.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1444956139.2737.7.camel@intel.com> (Dan J. Williams's message of "Fri, 16 Oct 2015 00:42:19 +0000")
>>>>> "Dan" == Williams, Dan J <dan.j.williams@intel.com> writes:
Dan> Martin pointed out that I broke compatibility by changing the sysfs
Dan> layout of the integrity attributes. Rather than add a sysfs-link
Dan> we can make this patch simpler by only moving struct blk_integrity
Dan> to request_queue and leave integrity_kobj where it is in gendisk.
Dan> Also undo the conversion of blk_integrity apis take a
Dan> request_queue. Through this simplification I also noticed that I
Dan> had broken blk_integrity_compare()
Dan> Here's the much smaller v3, and I also refreshed
Dan> for-4.4/blk-integrity
Much better.
I ran some test on our combined trees over the weekend and tripped a bug
on some SCSI configs. Turned out to be my fault so I'll repost with a
fixed patch 2.
You can either rebase on top of the new series or maybe Jens will merge
my patches first. Either way works for me.
In any case I'm OK with your latest changes. Feel free to add my
Acked-by.
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: martin.petersen@oracle.com (Martin K. Petersen)
Subject: [PATCH v2 10/12] block: move blk_integrity to request_queue
Date: Mon, 19 Oct 2015 22:24:27 -0400 [thread overview]
Message-ID: <yq1fv16gtus.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1444956139.2737.7.camel@intel.com> (Dan J. Williams's message of "Fri, 16 Oct 2015 00:42:19 +0000")
>>>>> "Dan" == Williams, Dan J <dan.j.williams at intel.com> writes:
Dan> Martin pointed out that I broke compatibility by changing the sysfs
Dan> layout of the integrity attributes. Rather than add a sysfs-link
Dan> we can make this patch simpler by only moving struct blk_integrity
Dan> to request_queue and leave integrity_kobj where it is in gendisk.
Dan> Also undo the conversion of blk_integrity apis take a
Dan> request_queue. Through this simplification I also noticed that I
Dan> had broken blk_integrity_compare()
Dan> Here's the much smaller v3, and I also refreshed
Dan> for-4.4/blk-integrity
Much better.
I ran some test on our combined trees over the weekend and tripped a bug
on some SCSI configs. Turned out to be my fault so I'll repost with a
fixed patch 2.
You can either rebase on top of the new series or maybe Jens will merge
my patches first. Either way works for me.
In any case I'm OK with your latest changes. Feel free to add my
Acked-by.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2015-10-20 2:24 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 19:59 [PATCH v2 00/12] blk-integrity lifetime fixes Dan Williams
2015-10-15 19:59 ` Dan Williams
2015-10-15 19:59 ` [PATCH v2 01/12] block: Move integrity kobject to struct gendisk Dan Williams
2015-10-15 19:59 ` Dan Williams
2015-10-23 20:21 ` Jeff Moyer
2015-10-23 20:21 ` Jeff Moyer
2015-10-15 19:59 ` [PATCH v2 02/12] block: Consolidate static integrity profile properties Dan Williams
2015-10-15 19:59 ` Dan Williams
2015-10-15 19:59 ` [PATCH v2 03/12] block: Reduce the size of struct blk_integrity Dan Williams
2015-10-15 19:59 ` Dan Williams
2015-10-15 20:00 ` [PATCH v2 04/12] block: Export integrity data interval size in sysfs Dan Williams
2015-10-15 20:00 ` Dan Williams
2015-10-15 20:00 ` [PATCH v2 05/12] block: Inline blk_integrity in struct gendisk Dan Williams
2015-10-15 20:00 ` Dan Williams
2015-10-15 20:00 ` [PATCH v2 06/12] md, dm, scsi, nvme, libnvdimm: drop blk_integrity_unregister() at shutdown Dan Williams
2015-10-15 20:00 ` Dan Williams
2015-10-15 20:00 ` [PATCH v2 07/12] md: suspend i/o during runtime blk_integrity_unregister Dan Williams
2015-10-15 20:00 ` Dan Williams
2015-10-15 20:00 ` [PATCH v2 08/12] nvme: " Dan Williams
2015-10-15 20:00 ` Dan Williams
2015-10-15 20:00 ` [PATCH v2 09/12] block: generic request_queue reference counting Dan Williams
2015-10-15 20:00 ` Dan Williams
2015-10-15 20:00 ` [PATCH v2 10/12] block: move blk_integrity to request_queue Dan Williams
2015-10-15 20:00 ` Dan Williams
2015-10-16 0:42 ` Williams, Dan J
2015-10-16 0:42 ` Williams, Dan J
2015-10-20 2:24 ` Martin K. Petersen [this message]
2015-10-20 2:24 ` Martin K. Petersen
2015-10-20 2:45 ` Simplify block integrity registration v2 Martin K. Petersen
2015-10-20 2:45 ` [PATCH 1/5] block: Move integrity kobject to struct gendisk Martin K. Petersen
2015-10-20 2:45 ` [PATCH 2/5] block: Consolidate static integrity profile properties Martin K. Petersen
2015-10-20 18:20 ` Dan Williams
2015-10-20 2:45 ` [PATCH 3/5] block: Reduce the size of struct blk_integrity Martin K. Petersen
2015-10-20 2:45 ` [PATCH 4/5] block: Export integrity data interval size in sysfs Martin K. Petersen
2015-10-20 2:45 ` [PATCH 5/5] block: Inline blk_integrity in struct gendisk Martin K. Petersen
2015-10-21 7:22 ` Simplify block integrity registration v2 Christoph Hellwig
2015-10-21 15:45 ` Dan Williams
2015-10-21 16:35 ` Martin K. Petersen
2015-10-15 20:00 ` [PATCH v2 11/12] block: blk_flush_integrity() for bio-based drivers Dan Williams
2015-10-15 20:00 ` Dan Williams
2015-10-15 20:00 ` [PATCH v2 12/12] block, libnvdimm, nvme: provide a built-in blk_integrity nop profile Dan Williams
2015-10-15 20:00 ` Dan Williams
2015-10-15 23:53 ` [PATCH v2 00/12] blk-integrity lifetime fixes Martin K. Petersen
2015-10-15 23:53 ` Martin K. Petersen
2015-10-16 0:06 ` Dan Williams
2015-10-16 0:06 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fv16gtus.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=axboe@fb.com \
--cc=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-nvdimm@ml01.01.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.