From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bernd Schubert <bschubert@ddn.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"neilb@suse.de" <neilb@suse.de>
Subject: Re: [RFC] Discard update for 3.19
Date: Fri, 07 Nov 2014 10:46:37 -0500 [thread overview]
Message-ID: <yq1fvdv9foi.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <F6E129D0B46B7F4B89EF4089CE55578C045C9146@LAX-EX-MB4.datadirect.datadirectnet.com> (Bernd Schubert's message of "Fri, 7 Nov 2014 12:11:07 +0000")
>>>>> "Bernd" == Bernd Schubert <bschubert@ddn.com> writes:
Bernd,
Bernd> I have seen data corruption on an Intel SSD 510 after sending
Bernd> WRITE SAME UNMAP. As far as I remember, these disks ignore writes
Bernd> after sending that command. Unmap worked fine, though. So
Bernd> possibly there is another blacklisting required.
Well, the 510 is a SATA drive and doesn't implement either command so
that would be an LSI SATL problem. I recall that we had some problems
with the LSI firmware blacklisting DRAT/RZAT on that particular drive so
I did the same in my libata patch.
I don't have any bugs open with WRITE SAME or UNMAP on recent LSI
firmware, though. We use it extensively here.
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bernd Schubert <bschubert@ddn.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
"linux-scsi\@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-ide\@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-fsdevel\@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"neilb\@suse.de" <neilb@suse.de>
Subject: Re: [RFC] Discard update for 3.19
Date: Fri, 07 Nov 2014 10:46:37 -0500 [thread overview]
Message-ID: <yq1fvdv9foi.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <F6E129D0B46B7F4B89EF4089CE55578C045C9146@LAX-EX-MB4.datadirect.datadirectnet.com> (Bernd Schubert's message of "Fri, 7 Nov 2014 12:11:07 +0000")
>>>>> "Bernd" == Bernd Schubert <bschubert@ddn.com> writes:
Bernd,
Bernd> I have seen data corruption on an Intel SSD 510 after sending
Bernd> WRITE SAME UNMAP. As far as I remember, these disks ignore writes
Bernd> after sending that command. Unmap worked fine, though. So
Bernd> possibly there is another blacklisting required.
Well, the 510 is a SATA drive and doesn't implement either command so
that would be an LSI SATL problem. I recall that we had some problems
with the LSI firmware blacklisting DRAT/RZAT on that particular drive so
I did the same in my libata patch.
I don't have any bugs open with WRITE SAME or UNMAP on recent LSI
firmware, though. We use it extensively here.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2014-11-07 15:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 5:08 [RFC] Discard update for 3.19 Martin K. Petersen
2014-11-07 5:08 ` [PATCH 1/3] libata: Whitelist SSDs that are known to properly return zeroes after TRIM Martin K. Petersen
2014-11-07 8:24 ` Christoph Hellwig
2014-11-07 15:37 ` Martin K. Petersen
2014-12-05 16:45 ` Paolo Bonzini
2014-12-05 22:58 ` Elliott, Robert (Server Storage)
2014-12-08 15:15 ` Theodore Ts'o
2014-12-08 15:28 ` James Bottomley
2014-12-08 22:59 ` One Thousand Gnomes
2014-11-07 5:08 ` [PATCH 2/3] sd: Disable discard_zeroes_data for UNMAP Martin K. Petersen
2014-11-07 8:25 ` Christoph Hellwig
2014-11-10 23:43 ` Paolo Bonzini
2014-11-07 5:08 ` [PATCH 3/3] block: Introduce blkdev_issue_zeroout_discard() function Martin K. Petersen
2014-11-07 8:26 ` Christoph Hellwig
2014-11-07 15:42 ` Martin K. Petersen
2014-11-07 16:20 ` Theodore Ts'o
2014-11-07 16:27 ` Martin K. Petersen
2014-11-14 20:22 ` Martin K. Petersen
2014-11-17 18:53 ` Darrick J. Wong
2014-11-11 0:04 ` Darrick J. Wong
2014-11-11 2:33 ` Martin K. Petersen
2014-11-17 19:28 ` [PATCH] block: create ioctl to discard-or-zeroout a range of blocks Darrick J. Wong
2014-11-07 12:09 ` [RFC] Discard update for 3.19 Bernd Schubert
2014-11-07 12:11 ` Bernd Schubert
2014-11-07 15:46 ` Martin K. Petersen [this message]
2014-11-07 15:46 ` Martin K. Petersen
2014-11-10 14:19 ` Christoph Hellwig
2014-11-12 18:40 ` Ewan Milne
2014-11-12 19:41 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fvdv9foi.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=bschubert@ddn.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.