From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: dgilbert@interlog.com
Cc: SCSI development list <linux-scsi@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 1/3] scsi_debug: scsi_cmnd->cmnd check and casts unnecessary
Date: Mon, 18 Aug 2014 08:37:28 -0400 [thread overview]
Message-ID: <yq1fvgux9br.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <53E0AFD2.3050202@interlog.com> (Douglas Gilbert's message of "Tue, 05 Aug 2014 12:20:02 +0200")
>>>>> "Doug" == Douglas Gilbert <dgilbert@interlog.com> writes:
Doug> This patch removes a NULL check for the scsi_cmnd::cmnd pointer
Doug> since many other instances in this driver and elsewhere assume it
Doug> is valid. Also redundant casts to 'unsigned char *' are removed as
Doug> the pointer has that type.
Doug> Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2014-08-18 12:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 10:20 [PATCH 1/3] scsi_debug: scsi_cmnd->cmnd check and casts unnecessary Douglas Gilbert
2014-08-18 12:37 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fvgux9br.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=dgilbert@interlog.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.