All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "sagi@grimberg.me" <sagi@grimberg.me>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"axboe@fb.com" <axboe@fb.com>,
	"Baldyga, Robert" <robert.baldyga@intel.com>,
	Keith Busch <kbusch@kernel.org>,
	"Rakowski, Michal" <michal.rakowski@intel.com>
Subject: Re: [PATCH 0/2] nvme: Add kernel API for admin command
Date: Wed, 18 Sep 2019 20:40:05 -0400	[thread overview]
Message-ID: <yq1h85986fu.fsf@oracle.com> (raw)
In-Reply-To: <20190918170956.GA19639@lst.de> (Christoph Hellwig's message of "Wed, 18 Sep 2019 19:09:56 +0200")


Christoph,

> On Wed, Sep 18, 2019 at 11:08:07AM -0600, Keith Busch wrote:
>> And yes, that bouncing is really nasty, but it's really only needed for
>> PRP, so maybe let's just not ignore that transfer mode and support
>> extended metadata iff the controller supports SGLs. We just need a
>> special SGL setup routine to weave the data and metadata.
>
> Well, what is the point?  If people really want to use metadata they
> should just buy a drive supporting the separate metadata pointer.  In
> fact I haven't had to deal with a drive that only supports interleaved
> metadata so far given how awkward that is to deal with.

Yep. There's a reason we did DIX...

-- 
Martin K. Petersen	Oracle Linux Engineering

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>,
	"sagi\@grimberg.me" <sagi@grimberg.me>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-nvme\@lists.infradead.org"
	<linux-nvme@lists.infradead.org>, "Rakowski\,
	Michal" <michal.rakowski@intel.com>,
	"axboe\@fb.com" <axboe@fb.com>, "Baldyga\,
	Robert" <robert.baldyga@intel.com>
Subject: Re: [PATCH 0/2] nvme: Add kernel API for admin command
Date: Wed, 18 Sep 2019 20:40:05 -0400	[thread overview]
Message-ID: <yq1h85986fu.fsf@oracle.com> (raw)
In-Reply-To: <20190918170956.GA19639@lst.de> (Christoph Hellwig's message of "Wed, 18 Sep 2019 19:09:56 +0200")


Christoph,

> On Wed, Sep 18, 2019 at 11:08:07AM -0600, Keith Busch wrote:
>> And yes, that bouncing is really nasty, but it's really only needed for
>> PRP, so maybe let's just not ignore that transfer mode and support
>> extended metadata iff the controller supports SGLs. We just need a
>> special SGL setup routine to weave the data and metadata.
>
> Well, what is the point?  If people really want to use metadata they
> should just buy a drive supporting the separate metadata pointer.  In
> fact I haven't had to deal with a drive that only supports interleaved
> metadata so far given how awkward that is to deal with.

Yep. There's a reason we did DIX...

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2019-09-19  0:40 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13 11:16 [PATCH 0/2] nvme: Add kernel API for admin command Robert Baldyga
2019-09-13 11:16 ` Robert Baldyga
2019-09-13 11:16 ` [PATCH 1/2] nvme: add API for sending admin commands by bdev Robert Baldyga
2019-09-13 11:16   ` Robert Baldyga
2019-09-16  6:36   ` kbuild test robot
2019-09-16  6:36     ` kbuild test robot
2019-09-13 11:16 ` [PATCH 2/2] nvme: add API for getting nsid " Robert Baldyga
2019-09-13 11:16   ` Robert Baldyga
2019-09-16  6:57   ` kbuild test robot
2019-09-16  6:57     ` kbuild test robot
2019-09-13 14:37 ` [PATCH 0/2] nvme: Add kernel API for admin command Christoph Hellwig
2019-09-13 14:37   ` Christoph Hellwig
2019-09-16  7:16   ` Baldyga, Robert
2019-09-16  7:16     ` Baldyga, Robert
2019-09-16  7:34     ` Christoph Hellwig
2019-09-16  7:34       ` Christoph Hellwig
2019-09-16 12:13       ` Baldyga, Robert
2019-09-16 12:13         ` Baldyga, Robert
2019-09-17 16:39         ` Keith Busch
2019-09-17 16:39           ` Keith Busch
2019-09-18 13:26           ` Christoph Hellwig
2019-09-18 13:26             ` Christoph Hellwig
2019-09-18 17:08             ` Keith Busch
2019-09-18 17:08               ` Keith Busch
2019-09-18 17:09               ` Christoph Hellwig
2019-09-18 17:09                 ` Christoph Hellwig
2019-09-19  0:40                 ` Martin K. Petersen [this message]
2019-09-19  0:40                   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1h85986fu.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=michal.rakowski@intel.com \
    --cc=robert.baldyga@intel.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.