All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Colin King <colin.king@canonical.com>,
	"James E . J . Bottomley" <jejb@linux.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: libfc: fix null pointer dereference on a null lport
Date: Fri, 12 Jul 2019 01:47:40 +0000	[thread overview]
Message-ID: <yq1h87s58hv.fsf@oracle.com> (raw)
In-Reply-To: <20190702091835.13629-1-colin.king@canonical.com> (Colin King's message of "Tue, 2 Jul 2019 10:18:35 +0100")


Hannes,

Please review!

> Currently if lport is null then the null lport pointer is dereference
> when printing out debug via the FC_LPORT_DB macro. Fix this by using
> the more generic FC_LIBFC_DBG debug macro instead that does not use
> lport.

-- 
Martin K. Petersen	Oracle Linux Engineering

WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Colin King <colin.king@canonical.com>,
	"James E . J . Bottomley" <jejb@linux.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: libfc: fix null pointer dereference on a null lport
Date: Thu, 11 Jul 2019 21:47:40 -0400	[thread overview]
Message-ID: <yq1h87s58hv.fsf@oracle.com> (raw)
In-Reply-To: <20190702091835.13629-1-colin.king@canonical.com> (Colin King's message of "Tue, 2 Jul 2019 10:18:35 +0100")


Hannes,

Please review!

> Currently if lport is null then the null lport pointer is dereference
> when printing out debug via the FC_LPORT_DB macro. Fix this by using
> the more generic FC_LIBFC_DBG debug macro instead that does not use
> lport.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2019-07-12  1:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02  9:18 [PATCH] scsi: libfc: fix null pointer dereference on a null lport Colin King
2019-07-02  9:18 ` Colin King
2019-07-12  1:47 ` Martin K. Petersen [this message]
2019-07-12  1:47   ` Martin K. Petersen
2019-07-12  6:34 ` Hannes Reinecke
2019-07-12  6:34   ` Hannes Reinecke
2019-07-12 10:43   ` Julia Lawall
2019-07-12 10:43     ` Julia Lawall
2019-07-17  2:32 ` Martin K. Petersen
2019-07-17  2:32   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1h87s58hv.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=colin.king@canonical.com \
    --cc=hare@suse.de \
    --cc=jejb@linux.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.