From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: Bart Van Assche <Bart.VanAssche@wdc.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"abdhalee@linux.vnet.ibm.com" <abdhalee@linux.vnet.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
"sachinp@linux.vnet.ibm.com" <sachinp@linux.vnet.ibm.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>
Subject: Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc
Date: Mon, 21 Aug 2017 16:27:12 -0400 [thread overview]
Message-ID: <yq1h8x0ekf3.fsf@oracle.com> (raw)
In-Reply-To: <0f7e2114-eba1-f149-ea80-d32d8b6d212a@linux.vnet.ibm.com> (Brian King's message of "Fri, 18 Aug 2017 16:57:59 -0500")
Brian,
>> Thanks for the detailed analysis. This is very helpful. Have you
>> considered to change the ipr driver such that it terminates REPORT
>> SUPPORTED OPERATION CODES commands with the appropriate check
>> condition code instead of DID_ERROR?
>
> Yes. That data is actually in the sense buffer, but since I'm also
> setting DID_ERROR, scsi_decide_disposition isn't using it. I've got a
> patch to do just as you suggest, to stop setting DID_ERROR when there
> is more detailed error data available, but it will need some
> additional testing before I submit, as it will impact much more than
> just this case.
I agree. In this case where a command is not supported, a check
condition would be a better way to signal the failure to the SCSI
midlayer.
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: Bart Van Assche <Bart.VanAssche@wdc.com>,
"linuxppc-dev\@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"abdhalee\@linux.vnet.ibm.com" <abdhalee@linux.vnet.ibm.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hch\@lst.de" <hch@lst.de>,
"linux-scsi\@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"sfr\@canb.auug.org.au" <sfr@canb.auug.org.au>,
"sachinp\@linux.vnet.ibm.com" <sachinp@linux.vnet.ibm.com>,
"linux-next\@vger.kernel.org" <linux-next@vger.kernel.org>,
"hare\@suse.com" <hare@suse.com>,
"mpe\@ellerman.id.au" <mpe@ellerman.id.au>
Subject: Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc
Date: Mon, 21 Aug 2017 16:27:12 -0400 [thread overview]
Message-ID: <yq1h8x0ekf3.fsf@oracle.com> (raw)
In-Reply-To: <0f7e2114-eba1-f149-ea80-d32d8b6d212a@linux.vnet.ibm.com> (Brian King's message of "Fri, 18 Aug 2017 16:57:59 -0500")
Brian,
>> Thanks for the detailed analysis. This is very helpful. Have you
>> considered to change the ipr driver such that it terminates REPORT
>> SUPPORTED OPERATION CODES commands with the appropriate check
>> condition code instead of DID_ERROR?
>
> Yes. That data is actually in the sense buffer, but since I'm also
> setting DID_ERROR, scsi_decide_disposition isn't using it. I've got a
> patch to do just as you suggest, to stop setting DID_ERROR when there
> is more detailed error data available, but it will need some
> additional testing before I submit, as it will impact much more than
> just this case.
I agree. In this case where a command is not supported, a check
condition would be a better way to signal the failure to the SCSI
midlayer.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-08-21 20:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 17:00 [BUG][bisected 270065e] linux-next fails to boot on powerpc Abdul Haleem
2017-08-16 17:21 ` Bart Van Assche
2017-08-16 17:21 ` Bart Van Assche
2017-08-16 23:18 ` Brian King
2017-08-17 15:52 ` Bart Van Assche
2017-08-17 15:52 ` Bart Van Assche
2017-08-18 21:04 ` Brian King
2017-08-18 21:17 ` [PATCH] ipr: Set no_report_opcodes for RAID arrays Brian King
2017-08-21 20:22 ` Martin K. Petersen
2017-08-21 20:22 ` Martin K. Petersen
2017-08-18 21:41 ` [BUG][bisected 270065e] linux-next fails to boot on powerpc Bart Van Assche
2017-08-18 21:41 ` Bart Van Assche
2017-08-18 21:57 ` Brian King
2017-08-18 22:13 ` Bart Van Assche
2017-08-18 22:13 ` Bart Van Assche
2017-08-21 22:11 ` [PATCH 0/2] Allow scsi_prep_fn to occur for retried commands Brian King
2017-08-21 22:13 ` [PATCH 1/2] scsi: Move scsi_cmd->jiffies_at_alloc initialization to allocation time Brian King
2017-08-21 22:16 ` Brian King
2017-08-21 22:40 ` [PATCHv2 " Brian King
2017-08-22 6:51 ` [PATCH " hch
2017-08-21 22:14 ` [PATCH 2/2] scsi: Preserve retry counter through scsi_prep_fn Brian King
2017-08-22 6:51 ` hch
2017-08-22 6:42 ` [PATCH 0/2] Allow scsi_prep_fn to occur for retried commands Abdul Haleem
2017-08-21 20:27 ` Martin K. Petersen [this message]
2017-08-21 20:27 ` [BUG][bisected 270065e] linux-next fails to boot on powerpc Martin K. Petersen
2017-08-17 1:33 ` Michael Ellerman
2017-08-17 1:33 ` Michael Ellerman
2017-08-16 20:25 ` Bart Van Assche
2017-08-16 20:25 ` Bart Van Assche
2017-08-17 7:06 ` Michael Ellerman
2017-08-17 7:06 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1h8x0ekf3.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Bart.VanAssche@wdc.com \
--cc=abdhalee@linux.vnet.ibm.com \
--cc=brking@linux.vnet.ibm.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=sachinp@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.