From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: qla2xxx-upstream@qlogic.com,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt
Date: Tue, 13 Jun 2017 01:12:07 +0000 [thread overview]
Message-ID: <yq1h8zkzo60.fsf@oracle.com> (raw)
In-Reply-To: <20170605172958.12844-1-colin.king@canonical.com> (Colin King's message of "Mon, 5 Jun 2017 18:29:58 +0100")
Colin,
> An earlier commit ed7fb808477b846bb2 ("scsi: qla2xxx: Remove redundant
> wait when target is stopped.") removed a null check on ha->tgt.tgt_ops
> and replaced it with a new check that null checked tgt, thus making
> the subsequent null check on tgt totally redundant. Remove it.
Applied to 4.13/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: qla2xxx-upstream@qlogic.com,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt
Date: Mon, 12 Jun 2017 21:12:07 -0400 [thread overview]
Message-ID: <yq1h8zkzo60.fsf@oracle.com> (raw)
In-Reply-To: <20170605172958.12844-1-colin.king@canonical.com> (Colin King's message of "Mon, 5 Jun 2017 18:29:58 +0100")
Colin,
> An earlier commit ed7fb808477b846bb2 ("scsi: qla2xxx: Remove redundant
> wait when target is stopped.") removed a null check on ha->tgt.tgt_ops
> and replaced it with a new check that null checked tgt, thus making
> the subsequent null check on tgt totally redundant. Remove it.
Applied to 4.13/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-06-13 1:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 17:29 [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt Colin King
2017-06-05 17:29 ` Colin King
2017-06-07 22:42 ` Madhani, Himanshu
2017-06-07 22:42 ` Madhani, Himanshu
2017-06-13 1:12 ` Martin K. Petersen [this message]
2017-06-13 1:12 ` Martin K. Petersen
2018-01-05 15:50 ` [PATCH][scsi-next] scsi: qla2xxx: remove redundant assignment of d Colin King
2018-01-05 15:50 ` Colin King
2018-01-10 21:50 ` Martin K. Petersen
2018-01-10 21:50 ` Martin K. Petersen
2018-12-10 23:33 ` [PATCH][scsi-next] scsi: qla2xxx: remove unused variable status Colin King
2018-12-10 23:33 ` Colin King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1h8zkzo60.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=qla2xxx-upstream@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.