All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Bradley Grove <linuxdrivers@attotech.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [SCSI] esas2r: remove redundant NULL check on buffer
Date: Thu, 16 Mar 2017 23:50:25 +0000	[thread overview]
Message-ID: <yq1inn8n5mm.fsf@oracle.com> (raw)
In-Reply-To: <20170315164624.17264-1-colin.king@canonical.com> (Colin King's message of "Wed, 15 Mar 2017 16:46:24 +0000")

Colin King <colin.king@canonical.com> writes:

> buffer is a pointer to the static char array event_buffer and
> therefore can never be null, so the check is redundant. Remove it.

Applied to 4.12/scsi-queue. Thank you!

-- 
Martin K. Petersen	Oracle Linux Engineering

WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Bradley Grove <linuxdrivers@attotech.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [SCSI] esas2r: remove redundant NULL check on buffer
Date: Thu, 16 Mar 2017 19:50:25 -0400	[thread overview]
Message-ID: <yq1inn8n5mm.fsf@oracle.com> (raw)
In-Reply-To: <20170315164624.17264-1-colin.king@canonical.com> (Colin King's message of "Wed, 15 Mar 2017 16:46:24 +0000")

Colin King <colin.king@canonical.com> writes:

> buffer is a pointer to the static char array event_buffer and
> therefore can never be null, so the check is redundant. Remove it.

Applied to 4.12/scsi-queue. Thank you!

-- 
Martin K. Petersen	Oracle Linux Engineering

  parent reply	other threads:[~2017-03-16 23:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15 16:46 [PATCH] [SCSI] esas2r: remove redundant NULL check on buffer Colin King
2017-03-15 16:46 ` Colin King
2017-03-16 21:09 ` Bradley Grove
2017-03-16 21:09   ` Bradley Grove
2017-03-16 23:50 ` Martin K. Petersen [this message]
2017-03-16 23:50   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1inn8n5mm.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=colin.king@canonical.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxdrivers@attotech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.