* [PATCH] scsi: ufs: rockchip: Improve RX noise immunity
@ 2026-10-29 7:24 ` Shawn Lin
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Lin @ 2026-10-29 7:24 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K . Petersen
Cc: Heiko Stuebner, linux-rockchip, linux-scsi, Shawn Lin
Program VND_RX_SAVE_DET_CTRL for each RX lane to raise the receiver's
tolerance against short transients on the incoming signal, as recommended
by the Rockchip PHY team.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/ufs/host/ufs-rockchip.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ufs/host/ufs-rockchip.c b/drivers/ufs/host/ufs-rockchip.c
index bac68f238e1c..87308c9b1070 100644
--- a/drivers/ufs/host/ufs-rockchip.c
+++ b/drivers/ufs/host/ufs-rockchip.c
@@ -82,6 +82,7 @@ static int ufs_rockchip_rk3576_phy_init(struct ufs_hba *hba)
ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(VND_RX_LINERESET_PVALUE2, SEL_RX_LANE0 + i), 0x02);
ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(VND_RX_LINERESET_OPTION, SEL_RX_LANE0 + i), 0xf6);
ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(VND_RX_POWER_SAVING_CTRL, SEL_RX_LANE0 + i), 0x69);
+ ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(VND_RX_SAVE_DET_CTRL, SEL_RX_LANE0 + i), 0x18);
}
/* disable the mphy DME_SET cfg */
--
2.25.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] scsi: ufs: rockchip: Improve RX noise immunity
@ 2026-10-29 7:24 ` Shawn Lin
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Lin @ 2026-10-29 7:24 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K . Petersen
Cc: Heiko Stuebner, linux-rockchip, linux-scsi, Shawn Lin
Program VND_RX_SAVE_DET_CTRL for each RX lane to raise the receiver's
tolerance against short transients on the incoming signal, as recommended
by the Rockchip PHY team.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/ufs/host/ufs-rockchip.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ufs/host/ufs-rockchip.c b/drivers/ufs/host/ufs-rockchip.c
index bac68f238e1c..87308c9b1070 100644
--- a/drivers/ufs/host/ufs-rockchip.c
+++ b/drivers/ufs/host/ufs-rockchip.c
@@ -82,6 +82,7 @@ static int ufs_rockchip_rk3576_phy_init(struct ufs_hba *hba)
ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(VND_RX_LINERESET_PVALUE2, SEL_RX_LANE0 + i), 0x02);
ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(VND_RX_LINERESET_OPTION, SEL_RX_LANE0 + i), 0xf6);
ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(VND_RX_POWER_SAVING_CTRL, SEL_RX_LANE0 + i), 0x69);
+ ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(VND_RX_SAVE_DET_CTRL, SEL_RX_LANE0 + i), 0x18);
}
/* disable the mphy DME_SET cfg */
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: ufs: rockchip: Improve RX noise immunity
2026-10-29 7:24 ` Shawn Lin
@ 2026-11-05 3:26 ` Martin K. Petersen
-1 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2026-11-05 3:26 UTC (permalink / raw)
To: Shawn Lin
Cc: James E . J . Bottomley, Martin K . Petersen, Heiko Stuebner,
linux-rockchip, linux-scsi
Shawn,
> Program VND_RX_SAVE_DET_CTRL for each RX lane to raise the receiver's
> tolerance against short transients on the incoming signal, as recommended
> by the Rockchip PHY team.
Applied to 7.4/scsi-fixes, thanks!
--
Martin K. Petersen
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: ufs: rockchip: Improve RX noise immunity
2026-10-29 7:24 ` Shawn Lin
@ 2026-11-09 3:55 ` Martin K. Petersen (Oracle)
-1 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen (Oracle) @ 2026-11-09 3:55 UTC (permalink / raw)
To: James E . J . Bottomley, Shawn Lin
Cc: Martin K . Petersen, Heiko Stuebner, linux-rockchip, linux-scsi
On Thu, 29 Oct 2026 15:24:55 +0800, Shawn Lin wrote:
> Program VND_RX_SAVE_DET_CTRL for each RX lane to raise the receiver's
> tolerance against short transients on the incoming signal, as recommended
> by the Rockchip PHY team.
Applied to 7.4/scsi-fixes, thanks!
[1/1] scsi: ufs: rockchip: Improve RX noise immunity
https://git.kernel.org/mkp/scsi/c/c84374cf4d2c
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-11-09 3:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-29 7:24 [PATCH] scsi: ufs: rockchip: Improve RX noise immunity Shawn Lin
2026-10-29 7:24 ` Shawn Lin
2026-11-05 3:26 ` Martin K. Petersen
2026-11-05 3:26 ` Martin K. Petersen
2026-11-09 3:55 ` Martin K. Petersen (Oracle)
2026-11-09 3:55 ` Martin K. Petersen (Oracle)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.