From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Matteo Croce <mcroce@redhat.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-bcache@vger.kernel.org,
linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
linux-nfs@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Anna Schumaker <anna.schumaker@netapp.com>,
Dan Williams <dan.j.williams@intel.com>,
Song Liu <song@kernel.org>,
Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Subject: Re: [PATCH v3] block: refactor duplicated macros
Date: Tue, 10 Mar 2020 22:42:17 -0400 [thread overview]
Message-ID: <yq1k13rr4s6.fsf@oracle.com> (raw)
In-Reply-To: <20200311002254.121365-1-mcroce@redhat.com> (Matteo Croce's message of "Wed, 11 Mar 2020 01:22:54 +0100")
Matteo,
> The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are
> defined several times in different flavours across the whole tree.
> Define them just once in a common header.
>
> While at it, replace replace "PAGE_SHIFT - 9" with
> "PAGE_SECTORS_SHIFT" too and rename SECTOR_MASK to PAGE_SECTORS_MASK.
Looks OK to me.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Matteo Croce <mcroce@redhat.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-bcache@vger.kernel.org,
linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
linux-nfs@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Anna Schumaker <anna.schumaker@netapp.com>,
Song Liu <song@kernel.org>,
Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Subject: Re: [PATCH v3] block: refactor duplicated macros
Date: Tue, 10 Mar 2020 22:42:17 -0400 [thread overview]
Message-ID: <yq1k13rr4s6.fsf@oracle.com> (raw)
In-Reply-To: <20200311002254.121365-1-mcroce@redhat.com> (Matteo Croce's message of "Wed, 11 Mar 2020 01:22:54 +0100")
Matteo,
> The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are
> defined several times in different flavours across the whole tree.
> Define them just once in a common header.
>
> While at it, replace replace "PAGE_SHIFT - 9" with
> "PAGE_SECTORS_SHIFT" too and rename SECTOR_MASK to PAGE_SECTORS_MASK.
Looks OK to me.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Matteo Croce <mcroce@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-raid@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-nvdimm@lists.01.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Guoqing Jiang <guoqing.jiang@cloud.ionos.com>,
linux-block@vger.kernel.org, Song Liu <song@kernel.org>,
linux-bcache@vger.kernel.org, xen-devel@lists.xenproject.org,
Ulf Hansson <ulf.hansson@linaro.org>,
Anna Schumaker <anna.schumaker@netapp.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [Xen-devel] [PATCH v3] block: refactor duplicated macros
Date: Tue, 10 Mar 2020 22:42:17 -0400 [thread overview]
Message-ID: <yq1k13rr4s6.fsf@oracle.com> (raw)
In-Reply-To: <20200311002254.121365-1-mcroce@redhat.com> (Matteo Croce's message of "Wed, 11 Mar 2020 01:22:54 +0100")
Matteo,
> The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are
> defined several times in different flavours across the whole tree.
> Define them just once in a common header.
>
> While at it, replace replace "PAGE_SHIFT - 9" with
> "PAGE_SECTORS_SHIFT" too and rename SECTOR_MASK to PAGE_SECTORS_MASK.
Looks OK to me.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-03-11 2:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 0:22 [PATCH v3] block: refactor duplicated macros Matteo Croce
2020-03-11 0:22 ` [Xen-devel] " Matteo Croce
2020-03-11 0:22 ` Matteo Croce
2020-03-11 2:42 ` Martin K. Petersen [this message]
2020-03-11 2:42 ` [Xen-devel] " Martin K. Petersen
2020-03-11 2:42 ` Martin K. Petersen
2020-03-11 11:20 ` Coly Li
2020-03-11 11:20 ` [Xen-devel] " Coly Li
2020-03-11 11:20 ` Coly Li
2020-03-11 12:58 ` Jens Axboe
2020-03-11 12:58 ` [Xen-devel] " Jens Axboe
2020-03-11 12:58 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1k13rr4s6.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=anna.schumaker@netapp.com \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=guoqing.jiang@cloud.ionos.com \
--cc=jejb@linux.ibm.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=song@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.