All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.garry@huawei.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	jejb@linux.vnet.ibm.com, linuxarm@huawei.com,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	Xiang Chen <chenxiang66@hisilicon.com>
Subject: Re: [PATCH v3 4/4] scsi: hisi_sas: Add support for DIF feature for v3 hw
Date: Tue, 04 Dec 2018 21:14:43 -0500	[thread overview]
Message-ID: <yq1k1kosorw.fsf@oracle.com> (raw)
In-Reply-To: <358aae82-394e-9df2-6b05-5af8e0f196b3@huawei.com> (John Garry's message of "Tue, 4 Dec 2018 12:16:54 +0000")


John,

> Are you happy for us to make DIX support in this driver "hisi_sas DIX
> experimental" short term?

That's entirely your call, it's your driver/controller.  I just want the
experimental tag to be due to reasons on *your* end.

If it's reasons on my end they'll need to get fixed. We shouldn't have
drivers circumventing features because of bugs in the core block/SCSI
code...

-- 
Martin K. Petersen	Oracle Linux Engineering

WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.garry@huawei.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	<jejb@linux.vnet.ibm.com>, <linuxarm@huawei.com>,
	<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
	Xiang Chen <chenxiang66@hisilicon.com>
Subject: Re: [PATCH v3 4/4] scsi: hisi_sas: Add support for DIF feature for v3 hw
Date: Tue, 04 Dec 2018 21:14:43 -0500	[thread overview]
Message-ID: <yq1k1kosorw.fsf@oracle.com> (raw)
In-Reply-To: <358aae82-394e-9df2-6b05-5af8e0f196b3@huawei.com> (John Garry's message of "Tue, 4 Dec 2018 12:16:54 +0000")


John,

> Are you happy for us to make DIX support in this driver "hisi_sas DIX
> experimental" short term?

That's entirely your call, it's your driver/controller.  I just want the
experimental tag to be due to reasons on *your* end.

If it's reasons on my end they'll need to get fixed. We shouldn't have
drivers circumventing features because of bugs in the core block/SCSI
code...

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2018-12-05  2:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-03 12:09 [PATCH v3 0/3] hisi_sas: DIF support John Garry
2018-12-03 12:09 ` John Garry
2018-12-03 12:09 ` [PATCH v3 1/4] scsi: hisi_sas: Fix warnings detected by sparse John Garry
2018-12-03 12:09   ` John Garry
2018-12-03 12:09 ` [PATCH v3 2/4] scsi: hisi_sas: Relocate some code to reduce complexity John Garry
2018-12-03 12:09   ` John Garry
2018-12-03 12:09 ` [PATCH v3 3/4] scsi: hisi_sas: Make sg_tablesize consistent value John Garry
2018-12-03 12:09   ` John Garry
2018-12-03 12:09 ` [PATCH v3 4/4] scsi: hisi_sas: Add support for DIF feature for v3 hw John Garry
2018-12-03 12:09   ` John Garry
2018-12-04  4:12   ` Martin K. Petersen
2018-12-04  4:12     ` Martin K. Petersen
2018-12-04 12:16     ` John Garry
2018-12-04 12:16       ` John Garry
2018-12-05  2:14       ` Martin K. Petersen [this message]
2018-12-05  2:14         ` Martin K. Petersen
2018-12-05 15:12         ` John Garry
2018-12-05 15:12           ` John Garry
2018-12-06  4:17           ` Martin K. Petersen
2018-12-06  4:17             ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1k1kosorw.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=john.garry@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.