From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Varun Prakash <varun@chelsio.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
dt@chelsio.com, indranil@chelsio.com, ganji.aravind@chelsio.com
Subject: Re: [PATCH net-next] cxgb4/libcxgb/cxgb4i/cxgbit: enable eDRAM page pods for iSCSI
Date: Wed, 29 May 2019 21:48:27 -0400 [thread overview]
Message-ID: <yq1lfyozp90.fsf@oracle.com> (raw)
In-Reply-To: <1559061660-4963-1-git-send-email-varun@chelsio.com> (Varun Prakash's message of "Tue, 28 May 2019 22:11:00 +0530")
Varun,
> Page pods are used for direct data placement, this patch enables eDRAM
> page pods if firmware supports this feature.
No objections to the SCSI bits.
> @@ -394,6 +398,26 @@ int cxgbi_ppm_init(void **ppm_pp, struct net_device *ndev,
> unsigned int pool_index_max = 0;
> unsigned int alloc_sz;
> unsigned int ppod_bmap_size;
> + unsigned int ppmax;
> +
> + if (!iscsi_edram_start)
> + iscsi_edram_size = 0;
> +
> + if (iscsi_edram_size &&
> + ((iscsi_edram_start + iscsi_edram_size) != start)) {
> + pr_err("iscsi ppod region not contigious: EDRAM start 0x%x "
contiguous
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Varun Prakash <varun@chelsio.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
dt@chelsio.com, indranil@chelsio.com, ganji.aravind@chelsio.com
Subject: Re: [PATCH net-next] cxgb4/libcxgb/cxgb4i/cxgbit: enable eDRAM page pods for iSCSI
Date: Thu, 30 May 2019 01:48:27 +0000 [thread overview]
Message-ID: <yq1lfyozp90.fsf@oracle.com> (raw)
In-Reply-To: <1559061660-4963-1-git-send-email-varun@chelsio.com> (Varun Prakash's message of "Tue, 28 May 2019 22:11:00 +0530")
Varun,
> Page pods are used for direct data placement, this patch enables eDRAM
> page pods if firmware supports this feature.
No objections to the SCSI bits.
> @@ -394,6 +398,26 @@ int cxgbi_ppm_init(void **ppm_pp, struct net_device *ndev,
> unsigned int pool_index_max = 0;
> unsigned int alloc_sz;
> unsigned int ppod_bmap_size;
> + unsigned int ppmax;
> +
> + if (!iscsi_edram_start)
> + iscsi_edram_size = 0;
> +
> + if (iscsi_edram_size &&
> + ((iscsi_edram_start + iscsi_edram_size) != start)) {
> + pr_err("iscsi ppod region not contigious: EDRAM start 0x%x "
contiguous
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-05-30 1:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 16:41 [PATCH net-next] cxgb4/libcxgb/cxgb4i/cxgbit: enable eDRAM page pods for iSCSI Varun Prakash
2019-05-28 16:53 ` Varun Prakash
2019-05-30 1:48 ` Martin K. Petersen [this message]
2019-05-30 1:48 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1lfyozp90.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=davem@davemloft.net \
--cc=dt@chelsio.com \
--cc=ganji.aravind@chelsio.com \
--cc=indranil@chelsio.com \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.