From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Kento.A.Kobayashi@sony.com,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Oliver Neukum <oneukum@suse.com>,
gregkh@linuxfoundation.org,
USB Storage list <usb-storage@lists.one-eyed-alien.net>,
Jacky.Cao@sony.com,
Kernel development list <linux-kernel@vger.kernel.org>,
SCSI development list <linux-scsi@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: uas: fix usb subsystem hang after power off hub port
Date: Tue, 09 Apr 2019 22:11:06 -0400 [thread overview]
Message-ID: <yq1lg0imwxx.fsf@oracle.com> (raw)
In-Reply-To: <1554823007.161891.6.camel@acm.org> (Bart Van Assche's message of "Tue, 09 Apr 2019 08:16:47 -0700")
Bart,
> From which context does that unbind happen? From inside a SCSI EH
> callback or from the context of a workqueue? I think the former is not
> allowed but that the latter is allowed. The SRP initiator driver
> (ib_srp.c) follows the latter approach.
Yeah. It's better to punt the actual tear down.
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Kento.A.Kobayashi@sony.com,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Oliver Neukum <oneukum@suse.com>,
gregkh@linuxfoundation.org,
USB Storage list <usb-storage@lists.one-eyed-alien.net>,
Jacky.Cao@sony.com,
Kernel development list <linux-kernel@vger.kernel.org>,
SCSI development list <linux-scsi@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: usb: uas: fix usb subsystem hang after power off hub port
Date: Tue, 09 Apr 2019 22:11:06 -0400 [thread overview]
Message-ID: <yq1lg0imwxx.fsf@oracle.com> (raw)
Bart,
> From which context does that unbind happen? From inside a SCSI EH
> callback or from the context of a workqueue? I think the former is not
> allowed but that the latter is allowed. The SRP initiator driver
> (ib_srp.c) follows the latter approach.
Yeah. It's better to punt the actual tear down.
next prev parent reply other threads:[~2019-04-10 2:11 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 9:13 [PATCH] usb: uas: fix usb subsystem hang after power off hub port Kento.A.Kobayashi
2019-03-08 9:13 ` Kento.A.Kobayashi
2019-03-08 9:13 ` Kento.A.Kobayashi
2019-03-08 16:52 ` [PATCH] " Oliver Neukum
2019-03-08 16:52 ` Oliver Neukum
2019-03-08 17:33 ` [PATCH] " Alan Stern
2019-03-08 17:33 ` Alan Stern
2019-03-08 17:33 ` Alan Stern
2019-03-11 8:36 ` [PATCH] " Kento.A.Kobayashi
2019-03-11 8:36 ` Kento.A.Kobayashi
2019-03-11 8:36 ` Kento.A.Kobayashi
2019-03-12 15:37 ` [PATCH] " Oliver Neukum
2019-03-12 15:37 ` Oliver Neukum
2019-03-15 2:28 ` [PATCH] " Kento.A.Kobayashi
2019-03-15 2:28 ` Kento.A.Kobayashi
2019-03-15 2:28 ` Kento.A.Kobayashi
2019-03-25 10:21 ` [PATCH] " Kento.A.Kobayashi
2019-03-25 10:21 ` Kento.A.Kobayashi
2019-03-25 10:21 ` Kento.A.Kobayashi
2019-03-25 10:34 ` [PATCH] " Oliver Neukum
2019-03-25 10:34 ` Oliver Neukum
2019-03-28 7:53 ` [PATCH] " Kento.A.Kobayashi
2019-03-28 7:53 ` Kento.A.Kobayashi
2019-03-28 7:53 ` Kento.A.Kobayashi
2019-03-28 15:15 ` [PATCH] " Oliver Neukum
2019-03-28 15:15 ` Oliver Neukum
2019-03-28 15:57 ` [PATCH] " Alan Stern
2019-03-28 15:57 ` Alan Stern
2019-03-28 15:57 ` Alan Stern
2019-03-28 16:49 ` [PATCH] " Oliver Neukum
2019-03-28 16:49 ` Oliver Neukum
2019-03-29 14:13 ` [PATCH] " Alan Stern
2019-03-29 14:13 ` Alan Stern
2019-03-29 14:13 ` Alan Stern
2019-04-02 0:28 ` [PATCH] " Kento.A.Kobayashi
2019-04-02 0:28 ` Kento.A.Kobayashi
2019-04-02 0:28 ` Kento.A.Kobayashi
2019-04-02 14:38 ` [PATCH] " Alan Stern
2019-04-02 14:38 ` Alan Stern
2019-04-02 14:38 ` Alan Stern
2019-04-04 3:57 ` [PATCH] " Kento.A.Kobayashi
2019-04-04 3:57 ` Kento.A.Kobayashi
2019-04-04 3:57 ` Kento.A.Kobayashi
2019-04-04 19:33 ` [PATCH] " Alan Stern
2019-04-04 19:33 ` Alan Stern
2019-04-04 19:33 ` Alan Stern
2019-04-09 0:28 ` [PATCH] " Kento.A.Kobayashi
2019-04-09 0:28 ` Kento.A.Kobayashi
2019-04-09 0:28 ` Kento.A.Kobayashi
2019-04-09 1:21 ` [PATCH] " Alan Stern
2019-04-09 1:21 ` Alan Stern
2019-04-09 1:21 ` Alan Stern
2019-04-09 2:10 ` [PATCH] " Martin K. Petersen
2019-04-09 2:10 ` Martin K. Petersen
2019-04-09 2:10 ` Martin K. Petersen
2019-04-09 14:44 ` [PATCH] " Alan Stern
2019-04-09 14:44 ` Alan Stern
2019-04-09 14:44 ` Alan Stern
2019-04-09 15:16 ` [PATCH] " Bart Van Assche
2019-04-09 15:16 ` Bart Van Assche
2019-04-09 15:16 ` Bart Van Assche
2019-04-09 15:16 ` Bart Van Assche
2019-04-09 16:45 ` [PATCH] " Alan Stern
2019-04-09 16:45 ` Alan Stern
2019-04-09 16:45 ` Alan Stern
2019-04-15 0:27 ` [PATCH] " Kento.A.Kobayashi
2019-04-15 0:27 ` Kento.A.Kobayashi
2019-04-15 0:27 ` Kento.A.Kobayashi
2019-04-15 15:18 ` [PATCH] " Alan Stern
2019-04-15 15:18 ` Alan Stern
2019-04-15 15:18 ` Alan Stern
2019-04-15 15:32 ` [PATCH] " Alan Stern
2019-04-15 15:32 ` Alan Stern
2019-04-15 15:32 ` Alan Stern
2019-04-16 2:31 ` [PATCH] " Kento.A.Kobayashi
2019-04-16 2:31 ` Kento.A.Kobayashi
2019-04-16 2:31 ` Kento.A.Kobayashi
2019-04-10 2:11 ` Martin K. Petersen [this message]
2019-04-10 2:11 ` Martin K. Petersen
[not found] <16EA1F625E922C43B00B9D8225022050086961B5@APYOKXMS108.ap.sony.com>
2019-03-04 6:23 ` [PATCH] " Greg KH
2019-03-04 7:19 ` Jacky.Cao
2019-03-04 7:19 ` Jacky.Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1lg0imwxx.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Jacky.Cao@sony.com \
--cc=Kento.A.Kobayashi@sony.com \
--cc=bvanassche@acm.org \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.