From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: QLogic-Storage-Upstream@cavium.com,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: qedf: Cleanup the type of io_log->op
Date: Tue, 09 May 2017 01:52:02 +0000 [thread overview]
Message-ID: <yq1r2zyssot.fsf@oracle.com> (raw)
In-Reply-To: <20170503212357.cdl4e43ihpyzl2w6@mwanda> (Dan Carpenter's message of "Thu, 4 May 2017 00:23:57 +0300")
Dan,
> We store sc_cmd->cmnd[0] which is an unsigned char in io_log->op so
> this should also be unsigned char. The other thing is that this is
> displayed in the debugfs:
Applied to 4.12/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: QLogic-Storage-Upstream@cavium.com,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: qedf: Cleanup the type of io_log->op
Date: Mon, 08 May 2017 21:52:02 -0400 [thread overview]
Message-ID: <yq1r2zyssot.fsf@oracle.com> (raw)
In-Reply-To: <20170503212357.cdl4e43ihpyzl2w6@mwanda> (Dan Carpenter's message of "Thu, 4 May 2017 00:23:57 +0300")
Dan,
> We store sc_cmd->cmnd[0] which is an unsigned char in io_log->op so
> this should also be unsigned char. The other thing is that this is
> displayed in the debugfs:
Applied to 4.12/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-05-09 1:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 21:23 [PATCH] scsi: qedf: Cleanup the type of io_log->op Dan Carpenter
2017-05-03 21:23 ` Dan Carpenter
2017-05-04 15:07 ` Chad Dupuis
2017-05-04 15:07 ` Chad Dupuis
2017-05-09 1:52 ` Martin K. Petersen [this message]
2017-05-09 1:52 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1r2zyssot.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=QLogic-Storage-Upstream@cavium.com \
--cc=dan.carpenter@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.