From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: sr: fix oob access in get_capabilities
Date: Wed, 15 Mar 2017 20:07:53 -0400 [thread overview]
Message-ID: <yq1r31yf5ie.fsf@oracle.com> (raw)
In-Reply-To: <1488536272-10509-1-git-send-email-wangkefeng.wang@huawei.com> (Kefeng Wang's message of "Fri, 3 Mar 2017 18:17:52 +0800")
Kefeng Wang <wangkefeng.wang@huawei.com> writes:
Kefeng,
> 'n = header_length + block_descriptor_length' could be greater than 512,
> and will lead to oob access, so enlarge transfer buffer to fix it.
Can you share the output of sg_modes -p 0x2a /dev/srN for the offending
drive?
This mode page is usually much smaller than 512 bytes (typically between
32 and 128 bytes).
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: sr: fix oob access in get_capabilities
Date: Wed, 15 Mar 2017 20:07:53 -0400 [thread overview]
Message-ID: <yq1r31yf5ie.fsf@oracle.com> (raw)
In-Reply-To: <1488536272-10509-1-git-send-email-wangkefeng.wang@huawei.com> (Kefeng Wang's message of "Fri, 3 Mar 2017 18:17:52 +0800")
Kefeng Wang <wangkefeng.wang@huawei.com> writes:
Kefeng,
> 'n = header_length + block_descriptor_length' could be greater than 512,
> and will lead to oob access, so enlarge transfer buffer to fix it.
Can you share the output of sg_modes -p 0x2a /dev/srN for the offending
drive?
This mode page is usually much smaller than 512 bytes (typically between
32 and 128 bytes).
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-03-16 0:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 10:17 [PATCH] scsi: sr: fix oob access in get_capabilities Kefeng Wang
2017-03-03 10:17 ` Kefeng Wang
2017-03-06 7:26 ` Kefeng Wang
2017-03-06 7:26 ` Kefeng Wang
2017-03-16 0:07 ` Martin K. Petersen [this message]
2017-03-16 0:07 ` Martin K. Petersen
2017-03-16 5:21 ` Kefeng Wang
2017-03-16 5:21 ` Kefeng Wang
2017-03-17 23:29 ` Martin K. Petersen
2017-03-17 23:29 ` Martin K. Petersen
2017-03-20 6:00 ` Kefeng Wang
2017-03-20 6:00 ` Kefeng Wang
2017-03-20 14:29 ` Martin K. Petersen
2017-03-20 14:29 ` Martin K. Petersen
2017-03-21 2:20 ` Kefeng Wang
2017-03-21 2:20 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1r31yf5ie.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.