From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@wdc.com>
Subject: Re: [PATCH v3 1/3] block: introduce zone_write_granularity limit
Date: Fri, 22 Jan 2021 21:43:02 -0500 [thread overview]
Message-ID: <yq1sg6sbche.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20210122080014.174391-2-damien.lemoal@wdc.com> (Damien Le Moal's message of "Fri, 22 Jan 2021 17:00:12 +0900")
Damien,
> To solve this, introduce the zone_write_granularity queue limit to
> indicate the alignment constraint, in bytes, of write operations into
> zones of a zoned block device. This new limit is exported as a
> read-only sysfs queue attribute and the helper
> blk_queue_zone_write_granularity() introduced for drivers to set this
> limit. The scsi disk driver is modified to use this helper to set
> host-managed SMR disk zone write granularity to the disk physical
> block size. The ZNS support code of the NVMe driver is also modified
> to use this helper to set the new limit to the logical block size of
> the namespace. The nullblk driver is similarly modified too.
Looks fine.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>, Keith Busch <keith.busch@wdc.com>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 1/3] block: introduce zone_write_granularity limit
Date: Fri, 22 Jan 2021 21:43:02 -0500 [thread overview]
Message-ID: <yq1sg6sbche.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20210122080014.174391-2-damien.lemoal@wdc.com> (Damien Le Moal's message of "Fri, 22 Jan 2021 17:00:12 +0900")
Damien,
> To solve this, introduce the zone_write_granularity queue limit to
> indicate the alignment constraint, in bytes, of write operations into
> zones of a zoned block device. This new limit is exported as a
> read-only sysfs queue attribute and the helper
> blk_queue_zone_write_granularity() introduced for drivers to set this
> limit. The scsi disk driver is modified to use this helper to set
> host-managed SMR disk zone write granularity to the disk physical
> block size. The ZNS support code of the NVMe driver is also modified
> to use this helper to set the new limit to the logical block size of
> the namespace. The nullblk driver is similarly modified too.
Looks fine.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-23 2:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 8:00 [PATCH v3 0/3] block: add zone write granularity limit Damien Le Moal
2021-01-22 8:00 ` Damien Le Moal
2021-01-22 8:00 ` [PATCH v3 1/3] block: introduce zone_write_granularity limit Damien Le Moal
2021-01-22 8:00 ` Damien Le Moal
2021-01-22 8:42 ` Christoph Hellwig
2021-01-22 8:42 ` Christoph Hellwig
2021-01-22 8:56 ` Damien Le Moal
2021-01-22 8:56 ` Damien Le Moal
2021-01-24 10:07 ` Christoph Hellwig
2021-01-24 10:07 ` Christoph Hellwig
2021-01-25 5:32 ` Damien Le Moal
2021-01-25 5:32 ` Damien Le Moal
2021-01-25 5:34 ` Damien Le Moal
2021-01-25 5:34 ` Damien Le Moal
2021-01-23 2:43 ` Martin K. Petersen [this message]
2021-01-23 2:43 ` Martin K. Petersen
2021-01-22 8:00 ` [PATCH v3 2/3] block: document zone_append_max_bytes attribute Damien Le Moal
2021-01-22 8:00 ` Damien Le Moal
2021-01-23 2:43 ` Martin K. Petersen
2021-01-23 2:43 ` Martin K. Petersen
2021-01-23 3:03 ` Chaitanya Kulkarni
2021-01-23 3:03 ` Chaitanya Kulkarni
2021-01-22 8:00 ` [PATCH v3 3/3] zonefs: use zone write granularity as block size Damien Le Moal
2021-01-22 8:00 ` Damien Le Moal
2021-01-22 8:42 ` Christoph Hellwig
2021-01-22 8:42 ` Christoph Hellwig
2021-01-23 2:44 ` Martin K. Petersen
2021-01-23 2:44 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1sg6sbche.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=hch@lst.de \
--cc=keith.busch@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.