From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] scsi: target: fix unsigned comparision with less than zero
Date: Thu, 21 Mar 2019 00:33:42 +0000 [thread overview]
Message-ID: <yq1sgvh5amx.fsf@oracle.com> (raw)
In-Reply-To: <20190320163709.28767-1-colin.king@canonical.com> (Colin King's message of "Wed, 20 Mar 2019 16:37:09 +0000")
Colin,
> Currently an error return is being assigned to an unsigned size_t
> varianle and then checked if the result is less than zero which will
> always be false. Fix this by making ret ssize_t rather than a size_t.
Applied to 5.2/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] scsi: target: fix unsigned comparision with less than zero
Date: Wed, 20 Mar 2019 20:33:42 -0400 [thread overview]
Message-ID: <yq1sgvh5amx.fsf@oracle.com> (raw)
In-Reply-To: <20190320163709.28767-1-colin.king@canonical.com> (Colin King's message of "Wed, 20 Mar 2019 16:37:09 +0000")
Colin,
> Currently an error return is being assigned to an unsigned size_t
> varianle and then checked if the result is less than zero which will
> always be false. Fix this by making ret ssize_t rather than a size_t.
Applied to 5.2/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-03-21 0:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 16:37 [PATCH][next] scsi: target: fix unsigned comparision with less than zero Colin King
2019-03-20 17:14 ` Mike Christie
2019-03-20 17:14 ` Mike Christie
2019-03-20 17:14 ` Colin Ian King
2019-03-20 17:15 ` Mike Christie
2019-03-20 17:15 ` Mike Christie
2019-03-21 0:33 ` Martin K. Petersen [this message]
2019-03-21 0:33 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1sgvh5amx.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.