From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Hannes Reinecke <hare@suse.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
y2038@lists.linaro.org, James Smart <james.smart@broadcom.com>,
linux-kernel@vger.kernel.org,
Johannes Thumshirn <jthumshirn@suse.de>,
Dick Kennedy <dick.kennedy@broadcom.com>
Subject: Re: [PATCH] scsi: lpfc: use monotonic timestamps for statistics
Date: Tue, 26 Jun 2018 12:00:54 -0400 [thread overview]
Message-ID: <yq1sh594jwp.fsf@oracle.com> (raw)
In-Reply-To: <20180618152903.1756535-1-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 18 Jun 2018 17:28:23 +0200")
Arnd,
> The get_seconds() function suffers from a possible overflow in 2038 or
> 2106, as well as jitter due to settimeofday or leap second updates,
> and is deprecated.
>
> As we are interested in elapsed time only, using ktime_get_seconds()
> to read the CLOCK_MONOTONIC timebase is ideal here. This also lets us
> remove the hack that tries to deal with get_seconds() going slightly
> backwards, which cannot happen with montonic timestamps.
Applied to 4.19/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
_______________________________________________
Y2038 mailing list
Y2038@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/y2038
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
y2038@lists.linaro.org, Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: lpfc: use monotonic timestamps for statistics
Date: Tue, 26 Jun 2018 12:00:54 -0400 [thread overview]
Message-ID: <yq1sh594jwp.fsf@oracle.com> (raw)
In-Reply-To: <20180618152903.1756535-1-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 18 Jun 2018 17:28:23 +0200")
Arnd,
> The get_seconds() function suffers from a possible overflow in 2038 or
> 2106, as well as jitter due to settimeofday or leap second updates,
> and is deprecated.
>
> As we are interested in elapsed time only, using ktime_get_seconds()
> to read the CLOCK_MONOTONIC timebase is ideal here. This also lets us
> remove the hack that tries to deal with get_seconds() going slightly
> backwards, which cannot happen with montonic timestamps.
Applied to 4.19/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-06-26 16:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 15:28 [PATCH] scsi: lpfc: use monotonic timestamps for statistics Arnd Bergmann
2018-06-25 7:49 ` Johannes Thumshirn
2018-06-25 7:49 ` Johannes Thumshirn
2018-06-26 16:00 ` Martin K. Petersen [this message]
2018-06-26 16:00 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1sh594jwp.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=arnd@arndb.de \
--cc=dick.kennedy@broadcom.com \
--cc=hare@suse.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.