From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>
Cc: nab@linux-iscsi.org, Bart.VanAssche@sandisk.com,
seroyer@linux.vnet.ibm.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ibmvscsis: Do not send aborted task response
Date: Wed, 19 Apr 2017 22:29:02 -0400 [thread overview]
Message-ID: <yq1tw5jq0b5.fsf@oracle.com> (raw)
In-Reply-To: <1491850368-7201-1-git-send-email-bryantly@linux.vnet.ibm.com> (Bryant G. Ly's message of "Mon, 10 Apr 2017 13:52:48 -0500")
"Bryant G. Ly" <bryantly@linux.vnet.ibm.com> writes:
> The driver is sending a response to the aborted task response along
> with LIO sending the tmr response. ibmvscsis_tgt does not send the
> response to the client until release_cmd time. The reason for this was
> because if we did it at queue_status time, then the client would be
> free to reuse the tag for that command, but we're still using the tag
> until the command is released at release_cmd time, so we chose to
> delay sending the response until then. That then caused this issue,
> because release_cmd is always called, even if queue_status is not.
>
> SCSI spec says that the initiator that sends the abort task TM NEVER
> gets a response to the aborted op and with the current code it will
> send a response. Thus this fix will remove that response if the TAS
> bit is set.
Somebody please review!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>
Cc: nab@linux-iscsi.org, Bart.VanAssche@sandisk.com,
seroyer@linux.vnet.ibm.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, <stable@vger.kernel.org>
Subject: Re: [PATCH] ibmvscsis: Do not send aborted task response
Date: Wed, 19 Apr 2017 22:29:02 -0400 [thread overview]
Message-ID: <yq1tw5jq0b5.fsf@oracle.com> (raw)
In-Reply-To: <1491850368-7201-1-git-send-email-bryantly@linux.vnet.ibm.com> (Bryant G. Ly's message of "Mon, 10 Apr 2017 13:52:48 -0500")
"Bryant G. Ly" <bryantly@linux.vnet.ibm.com> writes:
> The driver is sending a response to the aborted task response along
> with LIO sending the tmr response. ibmvscsis_tgt does not send the
> response to the client until release_cmd time. The reason for this was
> because if we did it at queue_status time, then the client would be
> free to reuse the tag for that command, but we're still using the tag
> until the command is released at release_cmd time, so we chose to
> delay sending the response until then. That then caused this issue,
> because release_cmd is always called, even if queue_status is not.
>
> SCSI spec says that the initiator that sends the abort task TM NEVER
> gets a response to the aborted op and with the current code it will
> send a response. Thus this fix will remove that response if the TAS
> bit is set.
Somebody please review!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-04-20 2:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 18:52 [PATCH] ibmvscsis: Do not send aborted task response Bryant G. Ly
2017-04-10 18:52 ` Bryant G. Ly
2017-04-20 2:29 ` Martin K. Petersen [this message]
2017-04-20 2:29 ` Martin K. Petersen
2017-04-25 20:18 ` Tyrel Datwyler
2017-05-02 4:19 ` Nicholas A. Bellinger
-- strict thread matches above, loose matches on Subject: below --
2017-04-07 15:49 Bryant G. Ly
2017-04-07 15:49 ` Bryant G. Ly
2017-04-07 15:56 ` Bryant G. Ly
2017-04-07 16:02 ` Bart Van Assche
[not found] ` <5297a130-5349-1796-2fe4-2336daa346ab@linux.vnet.ibm.com>
2017-04-07 16:36 ` Bart Van Assche
2017-04-07 17:01 ` Bryant G. Ly
2017-04-07 21:14 ` Michael Cyr
2017-04-07 21:23 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1tw5jq0b5.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=bryantly@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=seroyer@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.