All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-scsi@vger.kernel.org,
	"James E.J. Bottomley" <JBottomley@parallels.com>,
	Douglas Gilbert <dgilbert@interlog.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 3/6] scsi_debug: clear correct memory region when LBPRZ is enabled
Date: Wed, 24 Apr 2013 21:42:06 -0400	[thread overview]
Message-ID: <yq1txmvtmhd.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1366117920-11740-4-git-send-email-akinobu.mita@gmail.com> (Akinobu Mita's message of "Tue, 16 Apr 2013 22:11:57 +0900")

>>>>> "Akinobu" == Akinobu Mita <akinobu.mita@gmail.com> writes:

Akinobu> The function unmap_region() clears memory region specified as
Akinobu> the logical block address and the number of logical blocks in
Akinobu> ramdisk storage (fake_storep) if lbpu and lbprz module
Akinobu> parameters are enabled.

Akinobu> In the while loop of unmap_region(), it advances optimal unmap
Akinobu> granularity in logical blocks.  But it only clears one logical
Akinobu> block at LBA 'block' per loop iteration.  And furthermore, the
Akinobu> 'block' is not pointing to a logical block address which should
Akinobu> be cleared, it is a index of probisioning map (map_storep).

Acked-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2013-04-25  1:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-16 13:11 [PATCH 0/6] scsi_debug: fix logical block provisioning support Akinobu Mita
2013-04-16 13:11 ` [PATCH 1/6] scsi_debug: call map_region() and unmap_region() only when needed Akinobu Mita
2013-04-25  1:59   ` Martin K. Petersen
2013-04-16 13:11 ` [PATCH 2/6] scsi_debug: prohibit scsi_debug_unmap_granularity == scsi_debug_unmap_alignment Akinobu Mita
2013-04-25  1:37   ` Martin K. Petersen
2013-04-16 13:11 ` [PATCH 3/6] scsi_debug: clear correct memory region when LBPRZ is enabled Akinobu Mita
2013-04-25  1:42   ` Martin K. Petersen [this message]
2013-04-16 13:11 ` [PATCH 4/6] scsi_debug: add translation functions between LBA and index of provisioning map Akinobu Mita
2013-04-25  1:43   ` Martin K. Petersen
2013-05-02 22:50   ` James Bottomley
2013-04-16 13:11 ` [PATCH 5/6] scsi_debug: fix initialization " Akinobu Mita
2013-04-25  1:44   ` Martin K. Petersen
2013-04-16 13:12 ` [PATCH 6/6] scsi_debug: fix logical block provisioning support Akinobu Mita
2013-04-25  1:46   ` Martin K. Petersen
2013-04-24 23:39 ` [PATCH 0/6] " Douglas Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1txmvtmhd.fsf@sermon.lab.mkp.net \
    --to=martin.petersen@oracle.com \
    --cc=JBottomley@parallels.com \
    --cc=akinobu.mita@gmail.com \
    --cc=dgilbert@interlog.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.