From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Douglas Gilbert <dgilbert@interlog.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 2/6] scsi_debug: prohibit scsi_debug_unmap_granularity == scsi_debug_unmap_alignment
Date: Wed, 24 Apr 2013 21:37:01 -0400 [thread overview]
Message-ID: <yq1y5c7tmpu.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1366117920-11740-3-git-send-email-akinobu.mita@gmail.com> (Akinobu Mita's message of "Tue, 16 Apr 2013 22:11:56 +0900")
>>>>> "Akinobu" == Akinobu Mita <akinobu.mita@gmail.com> writes:
Akinobu> scsi_debug prohibits setting scsi_debug_unmap_alignment to be
Akinobu> greater than scsi_debug_unmap_granularity. But setting them to
Akinobu> be the same value is not prohibited. In this case, the only
Akinobu> difference with scsi_debug_unmap_alignment == 0 is the logical
Akinobu> blocks from 0 to scsi_debug_unmap_alignment - 1 cannot be
Akinobu> unmapped. But the difference is not properly handled in the
Akinobu> current code.
Akinobu> So this prohibits such unusual setting.
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2013-04-25 1:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 13:11 [PATCH 0/6] scsi_debug: fix logical block provisioning support Akinobu Mita
2013-04-16 13:11 ` [PATCH 1/6] scsi_debug: call map_region() and unmap_region() only when needed Akinobu Mita
2013-04-25 1:59 ` Martin K. Petersen
2013-04-16 13:11 ` [PATCH 2/6] scsi_debug: prohibit scsi_debug_unmap_granularity == scsi_debug_unmap_alignment Akinobu Mita
2013-04-25 1:37 ` Martin K. Petersen [this message]
2013-04-16 13:11 ` [PATCH 3/6] scsi_debug: clear correct memory region when LBPRZ is enabled Akinobu Mita
2013-04-25 1:42 ` Martin K. Petersen
2013-04-16 13:11 ` [PATCH 4/6] scsi_debug: add translation functions between LBA and index of provisioning map Akinobu Mita
2013-04-25 1:43 ` Martin K. Petersen
2013-05-02 22:50 ` James Bottomley
2013-04-16 13:11 ` [PATCH 5/6] scsi_debug: fix initialization " Akinobu Mita
2013-04-25 1:44 ` Martin K. Petersen
2013-04-16 13:12 ` [PATCH 6/6] scsi_debug: fix logical block provisioning support Akinobu Mita
2013-04-25 1:46 ` Martin K. Petersen
2013-04-24 23:39 ` [PATCH 0/6] " Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1y5c7tmpu.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=JBottomley@parallels.com \
--cc=akinobu.mita@gmail.com \
--cc=dgilbert@interlog.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.