[PATCH v3] scsi: ufs: core: Fix stale comment in ufshcd_mcq_config_nr_queues()

[PATCH v3] scsi: ufs: core: Fix stale comment in ufshcd_mcq_config_nr_queues()

[Shawn Lin]

The comment refers to "hba->dev_cmd_queue", but struct ufs_hba no longer
has such a member (it was removed when the dedicated hwq for device
commands was dropped). Reword it to describe the actual requirement:
the queue is a host controller capability and it serves both non-polled
SCSI commands and UFS device management commands.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Reviewed-by: Bean Huo <beanhuo@micron.com>
---

Changes in v3:
- improve commit message (Bean)
- collect tag from Bean

Changes in v2:
- address Bart's review comments

 drivers/ufs/core/ufs-mcq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
index df293b6..25e392f 100644
--- a/drivers/ufs/core/ufs-mcq.c
+++ b/drivers/ufs/core/ufs-mcq.c
@@ -183,8 +183,8 @@ static int ufshcd_mcq_config_nr_queues(struct ufs_hba *hba)
 	}
 
 	/*
-	 * Device should support at least one I/O queue to handle device
-	 * commands via hba->dev_cmd_queue.
+	 * At least one non-poll (HCTX_TYPE_DEFAULT) queue is required for
+	 * non-polled SCSI commands and UFS device management commands.
 	 */
 	if (hba_maxq == poll_queues) {
 		dev_err(hba->dev, "At least one non-poll queue required\n");
-- 
2.7.4

Re: [PATCH v3] scsi: ufs: core: Fix stale comment in ufshcd_mcq_config_nr_queues()

[Bart Van Assche]

On 10/18/26 5:34 PM, Shawn Lin wrote:
> The comment refers to "hba->dev_cmd_queue", but struct ufs_hba no longer
> has such a member (it was removed when the dedicated hwq for device
> commands was dropped). Reword it to describe the actual requirement:
> the queue is a host controller capability and it serves both non-polled
> SCSI commands and UFS device management commands.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Re: [PATCH v3] scsi: ufs: core: Fix stale comment in ufshcd_mcq_config_nr_queues()

[Martin K. Petersen]

Shawn,

> The comment refers to "hba->dev_cmd_queue", but struct ufs_hba no
> longer has such a member (it was removed when the dedicated hwq for
> device commands was dropped). Reword it to describe the actual
> requirement: the queue is a host controller capability and it serves
> both non-polled SCSI commands and UFS device management commands.

Applied to 7.4/scsi-staging, thanks!

-- 
Martin K. Petersen

Re: [PATCH v3] scsi: ufs: core: Fix stale comment in ufshcd_mcq_config_nr_queues()

[Martin K. Petersen (Oracle)]

On Mon, 19 Oct 2026 08:34:22 +0800, Shawn Lin wrote:

> The comment refers to "hba->dev_cmd_queue", but struct ufs_hba no longer
> has such a member (it was removed when the dedicated hwq for device
> commands was dropped). Reword it to describe the actual requirement:
> the queue is a host controller capability and it serves both non-polled
> SCSI commands and UFS device management commands.
> 
> 
> [...]

Applied to 7.4/scsi-queue, thanks!

[1/1] scsi: ufs: core: Fix stale comment in ufshcd_mcq_config_nr_queues()
      https://git.kernel.org/mkp/scsi/c/a7ac98eb6c39

-- 
Martin K. Petersen