From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Kees Cook <keescook@chromium.org>
Cc: Justin Stitt <justinstitt@google.com>,
Tyrel Datwyler <tyreld@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] scsi: ibmvfc: replace deprecated strncpy with strscpy
Date: Tue, 05 Dec 2023 20:56:10 -0500 [thread overview]
Message-ID: <yq1v89cnlg6.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <202311301311.717549FB@keescook> (Kees Cook's message of "Thu, 30 Nov 2023 13:12:48 -0800")
Kees,
> On Mon, Oct 30, 2023 at 07:04:33PM +0000, Justin Stitt wrote:
>> strncpy() is deprecated for use on NUL-terminated destination strings
>> [1] and as such we should prefer more robust and less ambiguous string
>> interfaces.
> Yeah, this conversion looks correct to me too.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Applied to 6.8/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Kees Cook <keescook@chromium.org>
Cc: Tyrel Datwyler <tyreld@linux.ibm.com>,
linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
Justin Stitt <justinstitt@google.com>,
linuxppc-dev@lists.ozlabs.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] scsi: ibmvfc: replace deprecated strncpy with strscpy
Date: Tue, 05 Dec 2023 20:56:10 -0500 [thread overview]
Message-ID: <yq1v89cnlg6.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <202311301311.717549FB@keescook> (Kees Cook's message of "Thu, 30 Nov 2023 13:12:48 -0800")
Kees,
> On Mon, Oct 30, 2023 at 07:04:33PM +0000, Justin Stitt wrote:
>> strncpy() is deprecated for use on NUL-terminated destination strings
>> [1] and as such we should prefer more robust and less ambiguous string
>> interfaces.
> Yeah, this conversion looks correct to me too.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Applied to 6.8/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-12-06 1:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 19:04 [PATCH] scsi: ibmvfc: replace deprecated strncpy with strscpy Justin Stitt
2023-10-30 19:04 ` Justin Stitt
2023-11-30 21:12 ` Kees Cook
2023-11-30 21:12 ` Kees Cook
2023-12-06 1:56 ` Martin K. Petersen [this message]
2023-12-06 1:56 ` Martin K. Petersen
2023-12-14 4:29 ` Martin K. Petersen
2023-12-14 4:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1v89cnlg6.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=christophe.leroy@csgroup.eu \
--cc=jejb@linux.ibm.com \
--cc=justinstitt@google.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.